search

boppreh / steamgrid

Downloads images to fill your Steam grid view
MIT License
671 stars 42 forks source link

Covers not showing in steam #85

Closed LucyLikesYourFace closed 3 years ago

LucyLikesYourFace commented 3 years ago

I am running steamgrid v3.2.1 on Manjaro and whilst it detects my non steam games fine and finds assets for them, these do not show in steam, except for in big picture. The images are in the grid folder but are not being picked up. Adding custom artwork via steam works, but creates a file with a different name/id (2493935266p.png instead of 4186400503p.png) I am unsure if this is expected or not

su-thomas commented 3 years ago

I am running steamgrid 3.2.1 on macOS Catalina and getting the same issue as @LucyLikesYourFace

dhruvinsh commented 3 years ago

Yes that is correct. The issue is, cover is being downloaded but the ID (name) of the cover is different.

For example, Game called DeadCell: cover downloaded by steamgrid is, 3495713025p.png but required name need to be 3469739720p.png

I did manual cover set, and there after it worked fine.

Lucki commented 3 years ago

Could you please try v3.2.0? The only change to v3.2.1 had something to do with this.

LucyLikesYourFace commented 3 years ago

Could you please try v3.2.0? The only change to v3.2.1 had something to do with this.

just tried, 3.2.0 does not detect any non steam games at all Edit: Another thing, could this be anything? it seems an appid field was added https://developer.valvesoftware.com/w/index.php?title=Add_Non-Steam_Game&type=revision&diff=239018&oldid=235163

Lucki commented 3 years ago

I added a commit to #69 that should fix this.

LucyLikesYourFace commented 3 years ago

I've tried that out but it doesn't seem to work, the ids its showing isn't matching what steam is using and it didn't change the artwork

Lucki commented 3 years ago

Not sure what's wrong here. The target and name is correctly extracted and the crc32 number is also correct. The bit operations don't seem to do anything. The resulting name is the crc32 checksum. So I assume the bit shifting and the OR operations don't work the way they should but I'm not sure why.

A simple example if anyone want to tinker around: Target: "corsix-th" Name: CorsixTH Target + Name: "corsix-th"CorsixTH CRC32: 2209561550

Steam: 2257678613

https://github.com/SteamGridDB/steamgriddb-manager/blob/e293f97c53468374e15954da9c0ea2f27ca81c07/src/js/Steam.js#L195-L202

LucyLikesYourFace commented 3 years ago

I recreated the steps in python and im getting the same result steamgrid is for the id. Did steam itself change something?

Lucki commented 3 years ago

Did steam itself change something?

I think so. All the times I've checked with shortcuts that already existed and for them it still works totally fine. But it fails for newly created shortcuts - even if I set them to the old values. My current guess is that the new binary field is somehow connected.

Edit: It's the appid field directly as little endian.

Lucki commented 3 years ago

I added a commit to #69 that should fix this.

Now for real.

LucyLikesYourFace commented 3 years ago

Thank you, that fix works as far as I can tell

forenta commented 3 years ago

Could someone compile this to a 3.2.2 release?

ScranchNew commented 2 years ago

steamgrid.zip

I compiled the latest version of this repo for anyone still suffering from this bug. For me it fixed the problem. Use at your own discretion