search

botpress / nlu

This repo contains every ML/NLU related code written by Botpress in the NodeJS environment. This includes the Botpress Standalone NLU Server.
23 stars 21 forks source link

chore(core): added docker build/push to private repository #105

Closed michaelmass closed 3 years ago

michaelmass commented 3 years ago

added github action to build and push controller docker images

michaelmass commented 3 years ago

Yo @michaelmass the massive,

Ima be honest with you; I have no clue what this action does... XD

Will this action run on every push no matter what branch it is ? Where are these images being pushed ?

Does the SRE team needs a docker image for all branches on the nlu repo ?

What is this ./@actions/build/docker ?

What are all these secrets?

PAT (Personal Access Token ?), AWS_ECR_POLICY AWS_SECRET_ACCESS_KEY AWS_ROLE

Can I trust you on this one? Will this make my computer explode?

Having an image for every commit is really easier to test for now but maybe in the future, it is going to be overkill.

We are using this action to build/deploy docker images to our private repository. Here is an example of a workflow building using this action.

This ./@actions/build/docker is a reference to the action inside the botpress/actions repository.

The secrets are used to access the private docker repository.

Sure you can trust me 💯