fix(cli): fix max training parameter to allow the value 0

botpress / nlu

This repo contains every ML/NLU related code written by Botpress in the NodeJS environment. This includes the Botpress Standalone NLU Server.

23 stars 21 forks source link

Closed michaelmass closed 2 years ago

michaelmass commented 2 years ago

The max training cli option didn't allow the value 0. Setting max training to 0 will disable the training on the nlu server.

Since the value 0 is falsy in typescript it was using the default value for max training. By removing pickBy from lodash it is working properly.

michaelmass commented 2 years ago

lgtm @franklevasseur

franklevasseur commented 2 years ago

Lgtm @michaelmass 😂