feat(nlu-server): App tests

botpress / nlu

This repo contains every ML/NLU related code written by Botpress in the NodeJS environment. This includes the Botpress Standalone NLU Server.

23 stars 21 forks source link

feat(nlu-server): App tests #52

Closed spg closed 3 years ago

spg commented 3 years ago

Adds Express app tests (packages/nlu/src/nlu-server/app.test.ts) This is not an exhaustive test suite for the whole app. Rather, this PR's goal is to create the test infrastructure, to easily add future tests.

Had to move the server startup to packages/nlu/src/nlu-server/index.ts in order to not leave open handles that would prevent Jest from exiting cleanly.
For the same reason, also had to extract the chokidar Watcher

laurentlp commented 3 years ago

Nice work!!!! Pretty sure the package-lock file should be removed. And there seems to have some linting warnings. Other than that tested and looks fine to me!