botpress / nlu

This repo contains every ML/NLU related code written by Botpress in the NodeJS environment. This includes the Botpress Standalone NLU Server.
23 stars 21 forks source link

chore: extract engine in its own dedicated package #60

Closed franklevasseur closed 3 years ago

franklevasseur commented 3 years ago

Something I've been wanting to do for a long time now.

What needed to be done:

  1. Engine package has its own logger interface (the small one) and must be provided a Logger. There's no more clash between 2 different interfaces for Logger.
  2. Engine package reads the version directly from its package.json config file.
  3. Engine no more uses global fields of process. If a config is needed, it must be typed and passed as a parameter. There are still few usage of environment variables, but they will eventually be removed and passed as typed config.
  4. Engine no longer copies assets to APP_DATA_PATH but instead reads directly from the assets directory.