search

bpierre / fontello-svg

Generate SVG icons from a Fontello icon set.
MIT License
65 stars 7 forks source link

Make compatible with grunt #9

Closed chimo closed 3 months ago

chimo commented 7 years ago

Ref. #1

bpierre commented 7 years ago

Thanks, it looks good!

Just one thing: I would like to keep the console output separated from the library itself (index.js), so that it can still be used as a module in a bigger project without polluting the console output.

What would you think about making fontelloSvg() return an EventEmitter object, emitting the messages to log? You can find an example of this in downloadSvgs().

chimo commented 7 years ago

Makes sense! I'll have a look at that later today

chimo commented 7 years ago

I made the changes a few days ago. Let me know if anything else should be modified!