Closed 7FM closed 4 years ago
Add on init.py
__plugin_pythoncompat__ = ">=2.7,<4"
like this.
plugin_name = "Exclude Region" plugin_pythoncompat = ">=2.7,<4" plugin_implementation = None plugin_hooks = None
Add on init.py
__plugin_pythoncompat__ = ">=2.7,<4"
like this.
plugin_name = "Exclude Region" plugin_pythoncompat = ">=2.7,<4" plugin_implementation = None plugin_hooks = None
As mentiened I do not have (a lot) pyhton experience. I have already added the flag thats why I do not really understand your point. Does the order matter? Or is it rather convention? (I am just trying to understand)
Thanks for the PR! Looks good to me. I'll take a crack at reviewing/updating the tests. Hopefully there aren't too many changes required in those 🤞
Due to missing python experience I basically run 2to3 on all python files but only commited the non-testing files. In the unit tests 2to3 wants changes like:
But as I dont know if this might break python 2 compability and those changes where only for test files I left them untouched. The plugin loads as expected in octoprint with python 3 but I did not yet try if functionallity works too.