search

bradcfisher / OctoPrint-ExcludeRegionPlugin

OctoPrint plugin that adds the ability to prevent printing within rectangular or circular regions of the currently active gcode file.
GNU Affero General Public License v3.0
55 stars 5 forks source link

Support both python2 and python3 [#32] #39

Closed bradcfisher closed 4 years ago

bradcfisher commented 4 years ago

Additional compatibility updates for Python 3 to address #32

ruedli commented 4 years ago

Thank you for your work. Is the upgrade downwards compatible, so may we expect the installed plugin to work with both Python 2 and Python 3? Will it be merged and then available through the normal plugin-repository?

nxvash commented 4 years ago

Any word on when python 3 compatibility will be available?

pfsmorigo commented 4 years ago

Looking forward for this support!

cp2004 commented 4 years ago

Hey @bradcfisher, I'm looking into plugins that are not yet compatible with Python 3 across the repository - this plugin is the most popular plugin that has not yet become compatible.

Please can we get this moving, since users want to be moving to Python 3 and OctoPrint will drop support for Python 2 in the next year (2021) - your plugin will no longer be usable for them, and it has at least 5.82k users running it.

I see that this is in progress, and if you would like some help doing this I am happy to give it a go - if you want to have a chat about it, you can find me on the OctoPrint discord server (as @cp2004) and we can look at what needs to be done, to get this plugin to Python 3 so it can continue to live as successfully as it has so far.

Thank you, and I hope to hear from you soon!

edit and if you are no longer interested in maintaining this plugin (it is really great) then I may put it up for adoption on the repository (and adopt it, potentially so it can keep working)

pfsmorigo commented 4 years ago

Hello. Please merge this request.

ira-bv commented 4 years ago

Until the maintainer finds the time to merge, I have done the following:

  1. Uninstall the plugin on my octopi (plus any other non-python3-compatible plugins)
  2. SSH to the RasPi, backup homedir and do the described procedure.
  3. install this plugin with "install plugin from URL" but use the branch zip rather than the master: https://github.com/bradcfisher/OctoPrint-ExcludeRegionPlugin/archive/feature/python3_compat.zip
  4. restart Octoprint
  5. looking good!
cp2004 commented 4 years ago

Users are continuing to migrate to Python 3, and this plugin does not work for them. @bradcfisher if you no longer have the time to maintain this plugin, I recommend putting it up for adoption and someone can either take over maintenance, or work on it with you to get this moving forwards.

ira-bv commented 4 years ago

@bradcfisher Thank you!!