search

bradfitz / go-issue-mirror

[old] precursor to golang.org/x/build/maintner/godata
24 stars 2 forks source link

cmd/servegoissues: Update for users API change. #18

Closed dmitshur closed 7 years ago

dmitshur commented 7 years ago

The users API has been changed to use string type instead of template.URL in https://github.com/shurcooL/users/commit/155c11a29d1e03a3b29f4f9d7068ca7bae9ebc27. See its commit message for rationale:

Given we're moving away from use of html/template (e.g., see shurcooL/notificationsapp#3 and shurcooL/Go-Package-Store#68), it's no longer worth it to import the entire html/template package only for its URL type.

It's simpler to use string and add URL to the variable name to indicate that it's a URL.

This PR updates the use of the API so that the build of cmd/servegoissues succeeds.

It also includes minor typo fix in a comment and a return statement simplification.

dmitshur commented 7 years ago

Thanks for merging!