Fix icons for Bookmark Bar Folders

SmokeyNerd commented 3 years ago

Test plan

See https://github.com/brave/brave-core/pull/10037

Description

Update bookmark folder icon to increase legibility and align better to user preferences.

Original description:

I am a web developer, and I manage different clients in my bookmark folders.

The new update, changed all the bookmark folder icons to be:

This has made it a little more bland and hard to separate the folders at a glance

Since the icon are the same color as the text now, everything kind of blends together

This wasn't the case prior, when a very visible yellow folder separated them

CURRENT: image|243x27

OLD: image|244x28

Design

MacOS + Linux

Windows

Assets

Figma: https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/?node-id=9%3A5824

worthdesigning commented 3 years ago

I prefer the yellow folders as well. The new folders are not visually useful. I noticed something wasn't right and then saw the new icons - not good.

bravo86 commented 3 years ago

I much prefer the yellow folders. It makes me think my brave browser is broken. Can we have a least an option to go back to yellow folder pls?

srirambv commented 3 years ago

cc: @karenkliu @simonhong @rebron

KDD777 commented 3 years ago

I hope Brave changes the bookmark folders back to yellow. Unfortunately, I am going to use my Chrome browser until they do.

bman00311 commented 3 years ago

Please change bookmark folder icons back to yellow

BararQ commented 3 years ago

They look like the icons did not load properly or I am playing some old 8-bit game. Especially when all my other icons have color. Making it a option I can change so I can opt out of it, or bring back the old folder icon Please.

davidmreid commented 3 years ago

It's obviously a big time screw-up by the brave developers at Brave--as changing the icons doesn't make sense--unless you made a big boo-boo. Get this fixed already my Brave peeps.

bobd64 commented 3 years ago

The change to grey/transparent folders icons in the latest update of Brave browser has made it difficult to use Brave. I use the Bookmark bar with folders to find my regularly used sites. This is now annoying to my eyes as there are no differentiation along the bar. I now have to scan back and forth to find the folder I need. The more I use it the more it irritates my eyes. I hope you allow the option of returning to the yellow folders. Somehow the change in colors is soothing to my eyes. the section with just bookmarks icons is much easier to read

gregeeh commented 3 years ago

I agree, please either change the bookmark folder back to yellow or give us a choice.

phempshall commented 3 years ago

I thought all my folders were empty. Here's a UI/UX thought...

Solid icons = has contents Outlined icons = empty

KDD777 commented 3 years ago

The UI/UX argument given above by User: Phempshall is a knock-down argument for yellow-colored folders rather than grey/clear folders. I don't know why the UI/UX people have such little power at Brave.

Brave is the 10th most popular Browser in the world (see: https://kinsta.com/browser-market-share/).

Brave has the potential to be the 6th or 7th most popular Browser in the world. But not if it makes rookie UI/UX mistakes like this.

I am going to continue to use my Chrome browser until this mistake is fixed.

But, I don't want to use Chrome. I want to use Brave. But not if it is going to be annoying from a UI/UX perspective.

Johann999 commented 3 years ago

The previous yellow icon made sense. It corresponded to the Windows folder icon, which is also yellow. For years, users have gotten used to this icon. There was absolutely no need to change this icon. Please undo this change, asap. Thank you.

Tramplr commented 3 years ago

Don't like the grey outline folder icons. Spent a bunch of time trying to "fix" this since I didn't realize it was a change. As the previous posters have said, please put it back or make a choice to opt in or out. I always say "if it ain't broke don't fix it".

bravo86 commented 3 years ago

Is there a way to roll back to an old version manually?

bsclifton commented 3 years ago

Thanks for the feedback folks! 😄 I've shared with the appropriate people - we should have a response soon

As for work-arounds, I took a look and unfortunately it doesn't seem the icons are overridable by extensions or themes ☹️

831Digital commented 3 years ago

+1. Bring the old icons back or at least give us a choice.

pHROZEN-gHOST commented 3 years ago

Wow. Please wake up. Imagine what would happen if COVID-19 vaccination were mandatory.

If you want the option to turf the yellow folders, make it just that ... an option so people have a choice. Leave the yellow folders as a default. Is that really too much to ask? Even the current version of Google Chrome allows yellow folders again.

JeffreyStevens commented 3 years ago

I thought my Brave was broken when the folder icons were no longer yellow. I kept trying to change the appearance to make them revert to the old icon. Colorless folder icons next to colored bookmark icons is awful. It's ok to admit you made a bad call here, just give us the option to go back.

thebigMoose commented 3 years ago

I thought I lost my bookmarks with this change. Totally missed the outline folder. PLEASE give us back the yellow folder

831Digital commented 3 years ago

Still nothing? I am about to ditch brave over this. I hate the way this looks.

bravo86 commented 3 years ago

tempted to move over to Edge where it also has ad blocks and the verticle tab that is natively supported.

karenkliu commented 3 years ago

Hi all, Brave product design team here. Thanks for all the feedback so far! We hear you and are working on a fix. It's important to us that we have a bookmark folder icon that works for everyone, and clearly some considerations were missed in the initial update. Please be patient as we get a fix into the queue.

pHROZEN-gHOST commented 3 years ago

Hi Karen,

Thanks for the feedback. I may be wrong. But I believe that Chromium was where the change occurred. Google Chrome also has the same backlash when this happened.

I think the change should have been an optional one which people could have selected in settings. People don't generally like forced changes.

The new folder icons look terrible on my theme which has not changed and probably never will. Many of us use themes. So I can imagine that this would have similar impact to others.

I appreciate the attention to this item. On Wednesday, August 18, 2021, 01:35:10 p.m. EDT, Karen @.***> wrote:

Hi all, product design team here. Thanks for all the feedback so far! We hear you and are working on a fix. It's important to us that we have a bookmark folder icon that works for everyone, and clearly some considerations were missed in the initial update. Please be patient as we get a fix into the queue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

bsclifton commented 3 years ago

@pHROZEN-gHOST the new icons are ones we had made actually - this happened with https://github.com/brave/brave-core/pull/9424. If we reverted that pull request / patch, it would go back to the old look and feel

Do you have a screenshot of your theme that you would be willing to share? (so we can see contrast / other problems)

pHROZEN-gHOST commented 3 years ago

This is current...

This is what it used to look like (taken from Chrome as it is now)...

The new icons are not consistent with what is in the bookmark manager. PLEASE don't change this too :-o

On Wednesday, August 18, 2021, 02:32:15 p.m. EDT, Brian Clifton ***@***.***> wrote:

@pHROZEN-gHOST the new icons are ones we had made actually - this happened with brave/brave-core#9424. If we reverted that pull request / patch, it would go back to the old look and feel

Do you have a screenshot of your theme that you would be willing to share? (so we can see contrast / other problems)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

bsclifton commented 3 years ago

@pHROZEN-gHOST dang - looks like the screenshots didn't post ☹️ If you're not able to get them, you can send over to clifton@brave.com and I can share w/ @karenkliu and design team

Johann999 commented 3 years ago

Please revert to the old yellow icons. Asap. Thank you.

raphaellueckl commented 3 years ago

Suggestion: Remove the icon for folders completely. It's using space for nothing and they all look the same.

pHROZEN-gHOST commented 3 years ago

Um no!

That would be like ... Remove clothes entirely. They are just taking space. On Thursday, August 19, 2021, 08:40:10 a.m. EDT, Raphael Lückl @.***> wrote:

Suggestion: Remove the icon for folders completely. It's using space for nothing and they all look the same.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

worthdesigning commented 3 years ago

Suggestion: Remove the icon for folders completely. It's using space for nothing and they all look the same.

My car won't start - it's out of petrol. Oh well - better throw it out.

Johann999 commented 3 years ago

Removing the icon is complete nonsense. Please do not do any further experiments. Just replace the current icon with the previous icon. I wait for the solution every hour ...

Cache22 commented 3 years ago

Like others this change has been difficult for me to adapt to. I have the bookmarks toolbar visible, and have thousands of bookmarks organized into multiple folder tiers (as I've done since the days of Netscape Navigator).

With the latest update changing the folder icon into just an outline, it is not only more difficult on my eyes when finding bookmarks, it also just looks really strange and out of place, since the basic outline style for the folder doesn't match the style of any of the favicons. (Not even a few I found that have wireframe-ish favicons look good next to the folder outline icons.)

I have been trying to adapt to the change, since often just using something different for a while goes a long way towards making new changes flow just as well (or better) than what came before. But for this particular folder design change, I'm still actively getting annoyed every time I use bookmarks, and it's still slowing down my workflow as badly as it did when the change was first introduced. (And most of the time I just start typing parts of the URL and use autocomplete, so for it's rather telling that I am noticing and getting annoyed by this as frequently as I am.)

I'm not against changes, in fact I'm the type of person that enjoys installing software updates (whether UX/UI changes, security, or anything else, something about watching software evolve a bit at a time is enjoyable). So I do like seeing new changes, and always keep an open mind since often adjusting to changes can also be difficult at first.

Unfortunately this particular change is just significantly UX breaking for me, and I have yet to be able to even begin adapting. I would really like to see the previous folder icon returned in the short term, but would still look forward to changes in the bookmark folder design, so long as it is something customizable. (I don't mean customizable per-folder, but just overall. ) Per-folder options as some have suggested would also be a nice to have, like the ability to drag a favicon.ico file onto a bookmark folder, however I think the best move in the short term is to simply reverse this particular change and discuss the possibility of additional future changes at a later time.

greenspeace commented 3 years ago

I'm going to add my complaint about this issue. With poor eyesight I now find it difficult to identify the Bookmarks Folders easily. This is a retrograde step in my opinion. The system wasn't broken so why was there a need to 'fix' it?

DeeCalf commented 3 years ago

Please revert Brave back to its previous yellow folders ASAP -- the current 'blank ones' look like folders a five year old would have to use in kindergarten.

In the meantime, what version of Brave would be best to revert back to, to avoid the current-version's blank folders? If you could provide a link for downloading the older version that would be great?

Fgrassano commented 3 years ago

Adding my voice to the rest, please put the yellow folders back :D

Johann999 commented 3 years ago

I was fed up with being annoyed by these icons every day. Brave did nothing about this. And it would appear that Brave unfortunately does not do anything in this regard. That's why I now also have the browser changed.

SingerGuy commented 3 years ago

Moving from something that easily communicates to something that blends into the noise of black text on gray background is mind boggling. Bring back the yellow folders!

Metatronovich commented 3 years ago

Please, this looks so bad. Please give an option to change the bookmark folder icon to something else or atleast back to the "full" one. thanks!

challo202 commented 3 years ago

Adding my voice to the list. The new blank icons suck.

thebigMoose commented 3 years ago

I can't believe it... you made them WORSE!! Now they are white outline on grey background

On Tue, Aug 31, 2021 at 8:46 PM challo202 @.***> wrote:

Adding my voice to the list. The new blank icons suck.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/17463#issuecomment-909765956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMFSJ3Q4AXETOZ6VNRDZTDT7VZXJANCNFSM5CBXDWVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

karenkliu commented 3 years ago

Hi all, Brave design team here - we are currently working on a "full" icon, which will be yellow for Windows. Thanks for all your patience!

Johann999 commented 3 years ago

You don't have to create a new icon. You just have to go back to the old icon.

wwwutz commented 3 years ago

You just have to go back to the old icon.

As far as I understood that's not possible. The 'new' icons are monocolor-vector graphics. Some dev deep inside decided that the UI now has to be flawlessly resizable. Pixel-icons would end up in 8-bit game style graphics on these new stylish Retina 6K displays almost everybody uses today.

The only solution I would see is to supply multicolor svg icons to mimic pixel bases icons. but hey... that'll be a lot of work. I don't even think multi color is supported.

Thunderbird > 68.12 also did this move to svg icons. I didn't even dare creating an issue there.

+1 for the brave devs and designer who at least react! Thanks for that!

JeffreyStevens commented 3 years ago

@karenkliu you will only fix Windows and not Mac?

bsclifton commented 3 years ago

@JeffreyStevens fix planned for all platforms 😄

bsclifton commented 3 years ago

OK folks - we got the icons (@karenkliu updated in the top post). Here's what they look like:

I'll try to knock this out this week 😄

thebigMoose commented 3 years ago

Good, good, that will do for us windows users.

On Wed, Sep 8, 2021 at 2:33 AM Brian Clifton @.***> wrote:

OK folks - we got the icons @.*** https://github.com/karenkliu updated in the top post). Here's what they look like: [image: image] https://user-images.githubusercontent.com/4733304/132458203-0c2c4db5-dbc2-4a26-80c4-8a0607092075.png

I'll try to knock this out this week 😄

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/17463#issuecomment-914958709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMFSJ4ZEFOXAKBGT7JARX3UA37VFANCNFSM5CBXDWVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bsclifton commented 3 years ago

OK folks - got a pull request open. Should be able to close this out tomorrow https://github.com/brave/brave-core/pull/10037

bsclifton commented 3 years ago

Code is merged; next Nightly will feature the icons. We're planning to uplift to release channel - so this will be in our next release

Thanks for the feedback all 😄

pHROZEN-gHOST commented 3 years ago

EXCELLENT! On Wednesday, September 8, 2021, 02:33:54 a.m. EDT, Brian Clifton @.***> wrote:

OK folks - we got the icons @.*** updated in the top post). Here's what they look like:

I'll try to knock this out this week 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

brave / brave-browser