Payments Never Contributes

[MoonRubles]

Description

Brave Payments keeps saying "next contribution on X", but when that date rolls around the date is advanced a month, still says "no previous contribution" and the balance in BAT has not changed. This has happened for a least 3 months. All similar issues I see are marked closed.

Steps to Reproduce

1. windows 10, always kept updated, brave also allowed to update when available.
2. add funds to wallet: "your wallet is ready!"
3. payments on
4. monthly budget is non-zero, and balance is much greater than monthly budget. see screenshot. "Next contribution Feb 16"
5. Date for next contribution arrives, next contribution date advances 1 month, balance doesnt change, no last contribution.
6. For two months, I had set the pinned percentages to add up to 100%, so other entries would be zero if auto include were on. For the next month, made sure the pinned percentages were less than 100%, so some "zero" type error might be prevented. Same behavior.

Actual result:

Expected result:

The balance should reduce when a payment date occurs, and there should be a record of past contributions.

Reproduces how often:

Always. 3 or 4 months/attempts

Brave Version

about:brave info:

Brave: 0.20.30 V8: 6.4.388.40 rev: 8b78402e7b3b91d44d8146cbe4dc8013592c33fd Muon: 4.7.9 OS Release: 10.0.16299 Update Channel: Release OS Architecture: x64 OS Platform: Microsoft Windows Node.js: 7.9.0 Brave Sync: v1.4.2 libchromiumcontent: 64.0.3282.119

Reproducible on current live release:

Im not sure what a live build is. Brave has updated several times over the duration of this problem (~Nov 2017 - Feb 2018)

Additional Information

[BobT36]

I'm having the exact same issue, for at least 3 months now my contributions have never actually been contributed. There are no contributions in my history and my balance has never gone down.

I have 47.50 BAT in my wallet. I have it set to contribute up to 50 BAT. I have a single YouTube channel there, verified, and Included. The payment set to 100%.

I expect as the date rolls around (Feb 16th previously), that it will send the payment (all my BAT) to the Youtube's Uphold account.

The actual result is it does not, it simply rolls the date forward (Now showing March 17th).

Am I doing something wrong?

OS: Windows 7 Ultimate x64. Version Info: Brave: 0.20.42 V8: 6.4.388.41 rev: 096c7cb3c75ebb518f72fc7d24bc2bbaedd50aed Muon: 4.8.2 OS Release: 6.1.7601 Update Channel: Release OS Architecture: x64 OS Platform: Microsoft Windows Node.js: 7.9.0 Brave Sync: v1.4.2 libchromiumcontent: 64.0.3282.140

[rjro]

Same, I was "Overdue" and now my next contribution date is set to next month. I also recently learned that payments aren't sent out until the 30th, so the actual date of your contribution doesn't matter, only that is within that timeframe. I wish they would be more transparent about this whole system. FWIW I'm on Mac.

I mean this is supposed to be the entire purpose for this browser to exist and it doesn't work, and it seems to appear frequently in the community. Would be great to have this fixed and a little more info.

[NejcZdovc]

@MoonRubles @BobT36 @rjro can you please go to Advance settings (gear icon on the payments page) and click Backup your wallet. Do you see something like this auditioning parchment facing infliction experimental detente surreal quadrangular embalming throwing linchpin missouri kadishim pee treacherously reward (of course you will have different words?

[rjro]

Yep, my wallet seed is still there.

[MoonRubles]

@NejcZdovc Yes, i have a nice long recovery key like you describe

[BobT36]

@NejcZdovc Hmm, I previously had the full key there, but now it only shows "a"...

Is there anything I can do here?

[LaurenWags]

+1s from community: https://community.brave.com/t/brave-payments-not-sending-next-contribution-is-listed-as-overdue/16429 https://community.brave.com/t/i-lost-all-my-bat/16392 https://community.brave.com/t/next-contribution-overdue/16319

[eljuno]

So, +1 from me. :smile:

Claimed two grants so I have 47,5 BAT on my Brave wallet. When claimed the first grant, contribution date is Overdue << I enable payments but not add funds for months. Date is not updated but I know it should be sent after 30 days.

In January, the date changed to Jan 20, then I claimed the second grant and the date pushed again to Feb 18. On Feb 18, date changed to Today, but the contribution never sent.

And now it said Overdue. I set 50 BAT as monthly budget in case that matter. Also backup code show the correct words.

[BobT36]

@eljuno Exactly the same as me. Same amount of bat, same budget, never paid out to the wallet I set.

Only difference is my wallet backup code only shows "a". I previously restored it from a backup as I switched computers, it showed fine at the time.

[evq]

@BobT36 I would recommend that you re-restore from your backup. If the wallet backup code shows up as "a" it is expected that you would not be able to contribute.

[BobT36]

@evq Thanks, fortunately I still had the backup file. Now shows my key correctly.

Hopefully it will actually make the contribution at some point.. I have a Youtube channel linked to a wallet pinned, with it set as Included and at 100%. As in the screenshot above really. (47.50 bat, 50 bat budget).

[evq]

@BobT36 @eljuno I wanted to check in on your contributions, while rereading this topic I realized that you both said that you set your budget to 50 BAT when you only have 47.5 BAT in grants.

~You'll need to set your budget lower than the amount you have in order for the contribution to go through. The monthly budget is not "up to 50 BAT", it is "50 BAT". Please let me know if that does not allow your contribution to go through.~ Edit: This is wrong, it should still go through.

Note that depending on when your second grant was accepted, you may have to wait a few more days for your contribution to be allowed through.

We are investigating the issue where the contribution date gets pushed back by 30 days when the contribution fails, this is not the intended behavior.

[eljuno]

@evq if I read and assume the FAQ correctly, if I have balance at least 90% of the monthly budget, it should be sent? https://brave.com/faq-payments/#user-notification

Also, it seems the contribution's sent today. 0 BAT on balance and contribution date pushed to next month. But I'm not receive any notification like your contribution sent and no history (see that grey clock icon).

[evq]

@eljuno You are correct, I was mistaken re: 90% of the contribution. I had originally believed that logic was not applying for grants but it is.

You should see the history and your notification appear soon. When there is not yet a statement this means that your browser is still in the voting process, there is a random delay element to this for anonymization purposes so it can take up to a few hours.

[eljuno]

Thanks for clarifying @evq. Will waiting for notification and history. I'll keep an eye on it and will notify you if it still not appear after a few hours/days. :smile:

[BobT36]

Mine still hasn't sent yet: Then again I only just restored my wallet when I posted, so that could have been affecting things. It now correctly still shows the full seed now, rather than just "a", so hopefully at some point it will actually happen.

I accepted both grants and had it set to do this for a good couple of months now, but it always just kept getting pushed back. Both December, January & Feb payments were missed.

[elsaber]

Same issue.

Brave 0.20.42 V8 6.4.388.41 rev 096c7cb Muon 4.8.2 OS Release 4.13.0-32-generic Update Channel Release OS Architecture x64 OS Platform Linux Node.js 7.9.0 Brave Sync v1.4.2 libchromiumcontent 64.0.3282.140

UPD (Feb. 24, 2018): My contribution has just been processed.

[NejcZdovc]

I think that contributions are now going trough, so will close this issue for now. Let's reopen it if we find any problems.

[cryptojennie]

+1 from community https://basicattentiontoken.rocket.chat/channel/general?msg=yytc2vgQr67b6vhyb

+1 from me as well, where my contribution got pushed away a month as well.

[LaurenWags]

+1 from community: https://community.brave.com/t/brave-payment-never-went-out/16905

[BobT36]

Mine still haven't sent. It's now showing March 17th. When can I expect it to?

[LaurenWags]

+1 from community: https://community.brave.com/t/brave-payments-not-sending-next-contribution-is-listed-as-overdue/16429/9

[BobT36]

Well the 30th has passed, still not sent. Is there anything I can do or more info I can provide?

I have one site (Youtube, linked to Brave Publisher Uphold wallet) included, with it set to Pinned, and 100%.

[rjro]

@BobT36 Your monthly budget is over your balance, it will never send

[BobT36]

@rjro yet @evq said if it's over 90% (this is 95%) then it still should be sent?

Besides doing it that way is silly as you could never send the full amount. If the budget is set higher than the balance it should just send everything you have.

[NumDeP]

I agree with @BobT36

@evq do you reckon replacing the 90% bit with offload remainder balance when account balance is low, should be applied as the default? (Unless of course Payments is turned off)

I suppose it may also be ever so slightly efficient as well, considering any background calculations of Brave deducing 90% would no longer be needed.

[cryptojennie]

Big +1 from community: https://www.reddit.com/r/BATProject/comments/82rx8v/frustrating_contribution_overdue_issue/

[LaurenWags]

+1 from rocketchat (via @cryptojennie ) - today a user was pushed back to April.

[MikeRogero]

+1 from me. Nothing new, my browser is acting the same as all the others above. I expected contributions to be made, that didn't happen. Net result, frustrated and feel this is a broken system which leads to moving on to other things.

[MoonRubles]

OP here, It's been a month = time for next schedule payment, last night. I got two banner messages over the last two days about how the payment was going to happen and I could review my payments. Was looking good... then last night, my browser completely froze and is now fragged. See #13474 Was this just a coincidence? Not sure, but the timing was suspicious: approaching midnight of the payment date.

• written from Chrome :(

[BobT36]

So my date was March 17th.. It hasn't even hit the 17th in the UK yet, (23:51), and it's now been pushed back to April 9th. Lol..

[eljuno]

+1 from community https://community.brave.com/t/unable-to-submit-contribution/18089?u=eljuno

[MatthewDLudwig]

I'm the +1 above and to me, it looks like there are two problems and not one. Are some people getting "Overdue" for their Next Contribution, and others simply moving on to the next month without contributing at all?

[BobT36]

Yup mine just keeps moving forward, rather than saying "Overdue".

[MatthewDLudwig]

That's interesting, I'm showing as Overdue still so is this something that we should separate into two issues? Either way, how can we move forward on figuring out what's causing these issues? Originally it was clearly caused by the recovery key just disappearing but now everything should be fine.

@BobT36 Did you have a converted BTC wallet or fresh wallet and obtained UGP BAT?

Right now I'm hoping there's something we can find that's different and causing two messages. I am using the same wallet from the BTC POC that had BTC in it converted. I've had issues with the "a" key so I've reloaded my key previously and also taken from the UGP. I don't believe I've added my own BAT but may have added a small number in the past, to see if that would trigger the payment to go through.

[BobT36]

@MatthewDLudwig Hmm I'm not sure. Any way to tell?

I thought it was just a BAT one, but I definitely remember reading the news about the BAT wallet coming in AFTER I started using Brave, so it could be either.

The BAT I have in that wallet is from both of the promo payouts we got.

[MatthewDLudwig]

No I'm not sure of a way to tell. If we could get some input from some team members on this I think we may be getting somewhere.

Currently it looks like Overdue may be related to the BTC POC wallets.

[MikeRogero]

Now we have another problem with this process. After several months of my contributions not clearing, the wallet successfully cleared on Friday - however the Contributor wallet on Upload was not credited with the distribution. So my wallet was deducted, but the funds never arrived. I'm losing faith.

[LaurenWags]

@mikeRogero - a contribution does not go from a user directly to a publisher. User contributions are placed in an escrow wallet prior to settlement. Settlement is when publishers receive the user contributions. Some additional information is available in the FAQs: https://brave.com/faq-payments/

[MoonRubles]

OP again -- partial success finally.

BATs have been removed, the date has incremented. However, it still says "no previous contribution". This might be related to my browser crashing, where I have just now fixed a bad session-store (#13330).

I'll wait another month to see if 1) it does not crash at payment time, 2) I finally get a previous contribution history entry.

[rjro]

I think what @MikeRogero is saying is that he can see the address he deposited his tokens to on Etherscan, and that they haven't moved into the wallet where Publishers are paid from since the Contribution has been processed.

I noticed this as well, but just assumed that funds weren't transferred until the end of the month.

[NejcZdovc]

@MoonRubles it takes some time for whole transaction to finish after BAT's are transferred. We are adding more description with https://github.com/brave/browser-laptop/issues/13423

[MoonRubles]

@NejcZdovc Yes, confirming that you are correct: it took a day but I got both a notification and an update to the payment settings view. My issues here seem fully addressed, thanks.

[LaurenWags]

@rjro - you are correct, settlement generally happens end of month/beginning of month 😄

[LaurenWags]

+1 from this twitter thread: https://twitter.com/RHerringbone/status/977670851704233984

[NejcZdovc]

+1 from #13156 (which is an old one, but just added it for tracking)

[mrose17]

I believe that will be address by bat-client@2.2.1, which will be in review tomorrow! so i'm going to pass this to @NejcZdovc as i'm doing bat-client and he'll update the package.json file!

[BobT36]

Alrighty, it previously kept getting moved back, last time said April 9th. This time when it hit that date, it now says "Overdue".

Progress(?)..

Edit: I just got a pop up bar at the top stating my "wallet is ready for a deposit" or something, and to "Add funds" or "Later". My wallet amount is within the required % though isn't it? (Why would I want to deposit less than the full amount..)

[MoonRubles]

OP here... It's BROKEN AGAIN! Worked last month, got notifications of impending payment, and showed a last contribution. This month it's back to its originally reported broken state: the date gets incremented a month without any browser notifications, shows "no prev contrib", and the balance did not go down: I'll check and report again next month...

[BobT36]

ooo!