Payments Never Contributes

[MoonRubles]

Description

Brave Payments keeps saying "next contribution on X", but when that date rolls around the date is advanced a month, still says "no previous contribution" and the balance in BAT has not changed. This has happened for a least 3 months. All similar issues I see are marked closed.

Steps to Reproduce

1. windows 10, always kept updated, brave also allowed to update when available.
2. add funds to wallet: "your wallet is ready!"
3. payments on
4. monthly budget is non-zero, and balance is much greater than monthly budget. see screenshot. "Next contribution Feb 16"
5. Date for next contribution arrives, next contribution date advances 1 month, balance doesnt change, no last contribution.
6. For two months, I had set the pinned percentages to add up to 100%, so other entries would be zero if auto include were on. For the next month, made sure the pinned percentages were less than 100%, so some "zero" type error might be prevented. Same behavior.

Actual result:

Expected result:

The balance should reduce when a payment date occurs, and there should be a record of past contributions.

Reproduces how often:

Always. 3 or 4 months/attempts

Brave Version

about:brave info:

Brave: 0.20.30 V8: 6.4.388.40 rev: 8b78402e7b3b91d44d8146cbe4dc8013592c33fd Muon: 4.7.9 OS Release: 10.0.16299 Update Channel: Release OS Architecture: x64 OS Platform: Microsoft Windows Node.js: 7.9.0 Brave Sync: v1.4.2 libchromiumcontent: 64.0.3282.119

Reproducible on current live release:

Im not sure what a live build is. Brave has updated several times over the duration of this problem (~Nov 2017 - Feb 2018)

Additional Information

[cryptojennie]

+1 from community https://www.reddit.com/r/BATProject/comments/8eh0r5/contribution_date_glitch_anyone_else_having_this/

[NejcZdovc]

+1 from #13878

[isjamesalive]

+1 for me with v0.22.22 including the last few releases on Win10 1709. Backing up and restoring wallet keys doesn't help. Next contribution date is always $now + 1 month.

[kioken]

+1 for me, lost my last contribution and previous contribution statements as well. So depressing.

[BobT36]

Uh, it's been "currently processing" for an awful long time... And the date keeps moving forwards too lol. It said 27th yesterday.

[LaurenWags]

+1 from community: https://community.brave.com/t/not-donating-money/20696

[kioken]

As of today this is what shows up. Does this mean my amazing content creators won't be seeing their hard work paid this month? I'm hoping May 11th changes to the end of this month, because it's not right for a glitch on the Brave side to cause my friends to not get paid. :( Happy it's being looked into though.

Brave: 0.22.669 V8: 6.6.346.24 rev: 6cda2e84f749e66409e9e3bca63f5796422e7edf Muon: 5.2.7 OS Release: 10.0.16299 Update Channel: Release OS Architecture: x64 OS Platform: Microsoft Windows Node.js: 7.9.0 Brave Sync: v1.4.2 libchromiumcontent: 66.0.3359.117

Windows 10

[BobT36]

Now mine's showing April 30th.. Still "Currently Processing".

[NejcZdovc]

@BobT36 so if you are pushed back only for 3 days, that means that you are hitting one rule in the client and not the server anymore. I would love to debug this process with you if you have time. Please let me know at nejc[at]brave.com and we can set up the call. Thank you

[BobT36]

Sure. I'll shoot you a message.

Hopefully our timezones line up enough, I'm on U.K time and work during the week.

It's now knocked forward to May 3rd.

[MatthewDLudwig]

Last Contribution March 22nd, Next contribution Overdue. My budget is 10 BAT and I have over 100 in the wallet. Any suggestions as to next steps? I have quite a few issues with the ledger, is it worth just uninstalling and clearing everything out before reinstalling?

[realuser]

Mine (version 0.22.669) also has been stuck in "Currently processing" for a few days now and the "Next contribution" contribution date inches forward

[bsclifton]

+1 from user (contacted me via email). No contributions since March 18th (code prior to 0.22.22 was reported as working; the March contribution happened)

[NejcZdovc]

@BobT36 created an issue for min browsing time #14000

[BobT36]

@nejcZdovc helped me diagnose my issue, seems I needed 30 mins total browsing time.

I've now accumulated 55m, so we'll see what happens on May the 6th when the next date is hit.

[isjamesalive]

@BobT36 @NejcZdovc Hey, is this 30 minutes per day or 30 minutes in total?

The reason I haven't been using Brave as frequently is precisely because my contributions weren't going through.

[NejcZdovc]

@isjamesalive it's 30min total browsing time in current contribution period

[BobT36]

Hmm been like this for a while. Something else is stopping it, it seems.

I did get a popup in the notification bar at the top encouraging me to add funds to my wallet. This should be enough though if the threshold is set correctly.

[NumDeP]

@BobT36 why does it look like your '%' bit is still editable? I only ask because do your reckon the client isn't recognizing the 100% as set, thus not contributing.

[NumDeP]

@NejcZdovc regarding your statement of 30min in contribution period, if my contribution date is 30th May, is my contribution period regarded as 24 hours from 00:01 to 23:59 and will it not send if I didn't effectively use the browser as much on that day, also would it not contribute the day after?

One other thing in reference to @BobT36 seeing as most of us in this topic are facing exactly what he's facing, what is the procedure for making the transfers/communications anonymous because I was wondering if users utilizing a full force vpn (standalone/desktop) service is prohibiting the contributions?

[da2x]

+1 how is this still an issue? Got a few hours of browsing on my ledger. Contribution has remained as overdue for four or five weeks already. Two different computers with their own wallet and I’m having the same problem on both systems.

[entity279]

For me it's solved (had my 1st payment in a while 2-3 days ago) So something was done for this issue, thought

[davidlecce]

I am also having the Next contribution: Overdue issue

Brave	0.22.669
V8	6.6.346.24
rev	6cda2e8
Muon	5.2.7
OS Release	10.0.17134
Update Channel	Release
OS Architecture	x64
OS Platform	Microsoft Windows
Node.js	7.9.0
Brave Sync	v1.4.2
libchromiumcontent	66.0.3359.117

[NejcZdovc]

@davidlecce @da2x I am more then happy to jump on a call and help you out to figurate it. Just send me an email to nejc[at]brave.com

[BobT36]

@NumDeP That was cause the "pin" button was clicked. Unsure exactly what that effects.

I've just unpinned it and it's now non-editable. Let's see if that changes anything.

Also this just popped up, I presume for me it's stuck overdue as the proper % threshold isn't being taken into account? Or is this unrelated:

[realuser]

@NejcZdovc are there any trouble shooting steps we can take without having a phone call?

[Miyayes]

@BobT36 Could it be that your issue is due to the fact that your monthly budget > wallet balance? (Note that your budget = 50, but your balance = 47.5.) I vaguely remember hearing that the payment simply won't go through if that is the case, though I may be misremembering. One's budget should be <= one's balance for any given month.

[eljuno]

@Miyayes Should work if the balance ~90% of monthly budget. And it works for me in the past. https://github.com/brave/browser-laptop/issues/13156#issuecomment-367794108.

[BobT36]

Ah-ha, got a Brave Update today, now it says:

However as @eljuno said above, shouldn't it be within the aforementioned threshold?

[Miyayes]

+2 from reddit. I queried for some additional info about whether the BAT is from UGP or self-funded, and how frequently they use Brave per month:

1. I initially deposited LTC using the browser which were converted to BAT. I believe those have been used up, and now my balance is UGP grants (Assuming FIFO disbursements).

2. Brave is my daily driver. I use it always unless a site doesn’t behave as expected.

   ---

3. I deposited my own BAT from my ETH wallet held for nearly a year. I also claimed additional BAT tokens through a UGP grant into the same wallet.

4. I mostly use the desktop browser now a few times a month to open up and allocate contributions. Sometimes I browse sites where I don't have fully functionality on Chrome. It's my backup browser. Switching over fully when V1.0 is out.

I have noticed that the next CONTRIBUTION DATE keeps getting pushed back a few days, consistently. Was May 17, 23, now 27.

https://www.reddit.com/r/BATProject/comments/8lbrdz/brave_wallet_payment_stuck_in_currently_processing/

[da2x]

Issue #14194 may be a variant of this. However, I eventually got a toolbar saying “Your Brave Payments account is waiting for a deposit.” even though my account balance fully covers my monthly budget.

[BobT36]

Had an update yesterday, still says the same "under budget" message though. All my BAT is from the giveaways.

I'm in no rush so I'll leave it as it is (budget 50BAT, Balance 47.50BAT) so we can test whenever the threshold gets fixed to work properly. Either way we're certainly seeing some progress now it's got to this stage.

[NumDeP]

I like how everyone is so patient on this issue despite it's one of their most integral USPs :)

I'm also surprised how @BobT36 has managed to retain all his BAT from giveaways considering they were supposed to be used/sent/payed to publishers within a specific time frame. Could that be a contributing factor to the issue at hand I wonder, pardon the pun.

[BobT36]

@NumDeP It better bloody not disappear or I'd be raging lol. Purposefully left it like this for testing.

But yes otherwise no rush on it. I doubt many people have a gargantuan amount in their brave wallet that they need to go somewhere right NOW. Plus the system is still in Beta ain't it? So issues like this are expected.

Happy to provide additional testing / info wherever need be, but at the moment it looks like my current issue is now the threshold rules not applying properly.

[NejcZdovc]

@NumDeP @BobT36 and everybody else of course that are so patiently waiting for this issue to be full fixed.

This process is sadly really long and we are improving it in every version. There are a lot of edge cases which are fixed thanks to all of you who are helping us with your reports. Next release is solely focused on contribution process (https://github.com/brave/browser-laptop/milestone/115), where we would like to speed it up and make is safer and more reliable.

Most of remanning contributions that are failing is due to a giveaways expiring which is not correctly reflected in the balance. We are working on a fix that will solve it. Problem is that for example grant expired, but because this was not reflected in the balance contribution is still triggered, even though that balance is not up to date and that's why contribution is stuck.

[evq]

@NumDeP @BobT36 et. al.

Hey all. Just wanted to report in to say that the fix mentioned is in place. Existing grants are now fully expired.

For anyone who has been actively trying to redeem expired grants and failed, we've gone ahead and made a deposit for the value of your grants to your wallets. You should see your contributions go through now, please let us know if you don't!

We're very sorry for the issues that resulted in your contributions getting pushed back in the first place and the poor failure mode post expiration, we've learned a lot as a result.

Thanks for your patience and understanding, eV

[da2x]

@evq Brave may have mesed up. I just had a failing payment go through. It’s in my payment history and everything. Fun fact: I had 15 BAT in this wallet. I just had a 15 BAT payment process. My wallet now contains 10 BAT. Contribution Statement shows 15 BAT. I even pulled up a backup from a few days ago to confirm that my account balance was 15 BAT. Update. I clicked on the monthly budget dropdown and my account balance dropped to 0. When I restart Brave it goes back up to 10 BAT until I click on the budget drop down again.

[evq]

hi @da2x are you still seeing this behavior? I was thinking you may be seeing a cached value sometimes, and non-cached at others. the cached value should have expired by now though, let me know if the problem is persisting

[BobT36]

@evq @NejcZdovc No worries, I don't mind how long it takes, as long as I don't actually lose the BAT lol.

Unsure if the changes are meant to be fully live or not, but my balance still shows as in the previous screenshot, (47.50 BAT, overdue contribution, balance under budget (despite being within threshold).

Again no problems on timescales, just letting you know. As mentioned I'm fine with leaving it how it is however long it takes, as I know how hard it is to diagnose problems without something to refer to. :)

Brave 0.22.721 V8 6.6.346.32 rev bfe7cdd

[da2x]

@evq I’m still seeing the same behaviour now.

[NumDeP]

Hi all, I’d like to make a couple of points if you don’t mind.

@BobT36 seems like we were on to something considering the comment by @NejcZdovc of 'most of remaining contributions that are failing is due to a giveaways expiring which is not correctly reflected in the balance' :)

Firstly @BobT36 you'll have to forgive me for mentioning this again but I don't know whether you understood @evq 's last comment because they seem to indicate ~despite the fact that those grants you think you still have (which have expired) they've recently sent those grants through to the designated publishers, which in your case is yourself, so technically you should have all the funds available in your wallet now and what you're seeing in your ledger client could possibly be a simple UI bug.~ ~Can you check your Uphold account please :)~ EDIT: They're expected to appear the following month.

One other thing in reference to my second point. Not that I'm accusing you of not appreciating our comments or respecting our suggestions because we greatly appreciate all your efforts not just for the ledger issues but one thing I'm sure many of us will appreciate is if the threshold limit is removed in favour of to always offload remainder balance when account balance is low. Perhaps it may just finally fix the issue. In addition, you can replace the notifications of encouraging users to add additional funds when contributions are about to be sent with something like, 'Is it alright that your your total sum for contributions is slightly under budget because we could wait for you to add additional funds' or along those lines.

[BobT36]

Hmm today I've checked and it's showing 0.00 balance in Brave, however the Payment History is greyed out (so presumably blank), and I have nothing in my Uphold wallet.

I presume that means they've expired? However I've received no deposit. My Brave wallet key is still showing fine now too btw.

[BobT36]

Hmm I just got a notification that 50 BAT had been processed, and now have a receipt in my payment history. Apparently 31/05/2018, 9:39PM was the contribution date, and 50 BAT not 47.5, is this normal?

Also haven't seen anything come through to my Uphold wallet yet, still says 0 pending balance. Presume it could take some time.

[evq]

@BobT36 glad that went through for you. I opened an issue to track the statement/receipt discrepancy you noted - #14319

FYI you may not see the balance go through to your publisher Uphold wallet until the 8th of next month. We make bulk settlements once a month and this contribution was right on the edge of the cutoff for the payout for June.

[evq]

@NumDeP We deposited funds for grants into user's browser wallets - not the publishers they're trying to pay. The latter is impossible due to the privacy guarantees we designed into our contributions system (namely we cannot identify that a given user has (or desires to) contribute to any given website/publisher)

As far as the threshold requirement goes, I would strongly recommend opening a new issue for this feature suggestion. This is the first time I've heard it, a separate issue would help us gauge interest, circulate for internal discussion, etc. Thanks for the suggestion.

[BobT36]

Oof, while to wait then, but like I said I don't mind. Just remind me to check next month and I'll confirm whether it worked.

Is there anything else you need from me to help testing / diagnosis? I've added my receipt and info to the issue you created.

Also as to the threshold rules, I'd second that it should work like so:

On budget change to one higher than the balance, display prompt to user: "Warning, this will use your total balance of 54.34BAT", then if ok'd, distribute the entire balance. Silly having like 3 BAT leftover or whatever. If user declines, reset the Budget to whatever it was previously.

[BobT36]

Just got an additional 15 free BAT today. :)

My next contribution date is 30th June. Have set budget to 15 this time since it matches bang on.

I'll hold off if need be though (since it shows I have till 10th October) Anything specific you guys want me to test? (Higher budget thresholds or whatever), or shall I just let them go through on the 30th.

[realuser]

Well, after several months (maybe 4?) my payment finally contributed!

[NumDeP]

Hi @evq I've got a question about the ledger. I have 35 BATs in my wallet, given the closest figures are 20 and 50 BATs, naturally contribution would go through if 20 is selected but what would happen if I left it at 50? I understand it doesn't fit the 90% threshold but what would happen, wouldn't the contributions go through at all and would I have to wait another month?

I've actually got a another question related to this but it's more befitting in the other topic I created a while back and updated recently, would you mind checking it out, I've cc'd you the comments there.

One other point, it isn't a huge issue but I thought I should report it for your information that the client notified me of my contribution being transferred in less than 24 hours today, however my client has always indicated that the 'Next contribution date: July 22nd', I don't mind it being 48 hours early but is it an error?

UPDATE: The same 24 hours notification appeared again 24 hours later and after that Overdue.

[BobT36]

Alright so this is a weird situation...

1. @evq That previous payment of 47.50 BAT still hasn't actually come through. However apparently 15 days ago a payment of 21 BAT was made to my Uphold (seems it was auto-converted to GBP too, so it's now only worth 16. Bah. I've now changed that setting for the future.): Brave Publisher statement for this year shows only that one 21.66 BAT payment being sent also. Now wasn't this supposed to be 47.50? If it's the same payment.. The only activity Brave browser shows in my history is that one 47.50 payment. (The receipt now shows the correct amount at least).

2. Also since then, I've accrued 35 BAT from the free promotion in Brave (shame there's no setting to send it all, so I had to set 20). It had a payment date set to the 20th July, but is now just showing "Overdue":