brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Payments Never Contributes #13156

Open MoonRubles opened 6 years ago

MoonRubles commented 6 years ago

Description

Brave Payments keeps saying "next contribution on X", but when that date rolls around the date is advanced a month, still says "no previous contribution" and the balance in BAT has not changed. This has happened for a least 3 months. All similar issues I see are marked closed.

Steps to Reproduce

  1. windows 10, always kept updated, brave also allowed to update when available.
  2. add funds to wallet: "your wallet is ready!"
  3. payments on
  4. monthly budget is non-zero, and balance is much greater than monthly budget. see screenshot. "Next contribution Feb 16"
  5. Date for next contribution arrives, next contribution date advances 1 month, balance doesnt change, no last contribution.
  6. For two months, I had set the pinned percentages to add up to 100%, so other entries would be zero if auto include were on. For the next month, made sure the pinned percentages were less than 100%, so some "zero" type error might be prevented. Same behavior.

Actual result:

bravepaymentcapture180215

Expected result:

The balance should reduce when a payment date occurs, and there should be a record of past contributions.

Reproduces how often:

Always. 3 or 4 months/attempts

Brave Version

about:brave info:

Brave: 0.20.30 V8: 6.4.388.40 rev: 8b78402e7b3b91d44d8146cbe4dc8013592c33fd Muon: 4.7.9 OS Release: 10.0.16299 Update Channel: Release OS Architecture: x64 OS Platform: Microsoft Windows Node.js: 7.9.0 Brave Sync: v1.4.2 libchromiumcontent: 64.0.3282.119

Reproducible on current live release:

Im not sure what a live build is. Brave has updated several times over the duration of this problem (~Nov 2017 - Feb 2018)

Additional Information

disfit commented 6 years ago

Chiming in on this issue with small differences or different behavior. First of all, I am currently on:

Brave: 0.23.39 V8: 6.7.288.46 rev: 3ee14b026f09d7d71c1985b4a9c9a11d78ab8f49 Muon: 7.1.6 OS Release: 4.15.0-29-generic Update Channel: Release OS Architecture: x64 OS Platform: Linux Node.js: 7.9.0 Brave Sync: v1.4.2 libchromiumcontent: 67.0.3396.103

I have had payments go through and have had issues in the past with my wallet & payments, see for instance issue #12122 (and in mails to @evq and @bsclifton: permission to share if useful). At this moment I have missed 2 consecutive payment windows. My partial contribution overview:

screenshot from 2018-07-26 09-00-57

After my last payment in May I claimed free tokens in June and then again in July. No screenshot for June, but here the before and after free-token-claim for July:

Before: screenshot from 2018-07-07 08-03-00

After: screenshot from 2018-07-07 08-03-42

At this moment the status has flipped to overdue again: screenshot from 2018-07-26 09-07-20

Two possibly related issues: I have noticed that it takes a longer time to load the payment screen (or parse the ledger). This now takes multiple seconds. This is also true for the Advanced Settings: here not for opening the pop up, but closing it. And the same is true for the Payment History pop up.

More troubling is that the recovery key for my wallet has changed at a certain moment. When I restore my wallet with the earlier recovery key I get a pop up that reports successful recovery. Yet the recovery key shown will still be the new one. Recovering my wallet with that new recovery key gives me a pop up with an error.

As before: I am happy to supply more information, logs and other help I can give.

BobT36 commented 6 years ago

Hmm not noticed any slowdown, however yes my recovery key is definitely different also. It's now a completely different (but valid looking) key than I had previously, as I backed it up when I was talking about it earlier in this thread.

My payments are still listed as overdue btw. I'm concerned that my 35 BAT from the free promotion will expire at some point. There's also the issue of the missing 26 BAT still outstanding..

BobT36 commented 6 years ago

So a couple of days ago I was getting constant popups that "Brave will pay your selected publishers in 24 hours" or something similar. It sat as "Overdue" for a couple of days in that time.

Now, it shows:

capture So is it actually going to pay or what? I'm worried that the expiry dates are closing in..

disfit commented 6 years ago

Same behavior here, though not pop ups, but a notification above the bookmark bar. Dismissing the notifications did not work as intended: the notification came back again and again.

My payment screen is also stating that the next contribution will be on September 17th and has been saying that since August 18th. However no August payment is showing in the history:

screenshot from 2018-08-20 08-25-13

BobT36 commented 6 years ago

Sorry I should have clarified it was a "notification" rather than a "pop-up". Basically the bar at the top that says payments would be sent in the next 24 hours blabblabla. I also had the same experience as @disfit where upon clicking dismiss, it kept coming back every now and again.

Seems we're both having the exact same experience here then.

BobT36 commented 6 years ago

So I claimed some more free BAT last night, however my payment date has now moved forward, again.. Also it's still not sent any of the previous lot for the last few months yet.

Only one month to go and then it starts expiring... capture

BobT36 commented 6 years ago

So September 20th rolls around, it pops up the notification bar saying it's going to be paid within 24 hours, then... capture

@evq @NejcZdovc any word on what's going on here? My BAT is going to start Expiring soon... :|

jacobrosenthal commented 6 years ago

Likewise. Ive taken like 5 grants and seen this happen every time. I got the pop up, the payment overdue, etc, etc. A bunch of funds disappeared from the account balance so maybe something happened? But I still don't have a payment history

BobT36 commented 6 years ago

@jacobrosenthal They could have just expired. See the dates, 15 of mine will expire in October, then 20 in November, then the rest in Jan lol. It's been like this for months.

jacobrosenthal commented 6 years ago

Im sure most of them have over the past 6 months as I dont think any of my payments have gone through. However the most recent ones werent due to expire until like oct/nov or something if I recall. But who knows, they disappeared.

NumDeP commented 6 years ago

I'm sure most you are aware by now that they're soon going to deprecate Brave-Laptop-Moun for Brave-Browser-Core which they've coherently working liked mad dogs on and they're really close to v1.0. If you have a look at their Road Map, they're close to completing all of the tasks situated for it.

In addition to this, I believe the new Brave will include the new 'overhauling of Brave Payments as Brave Rewards'. So I highly doubt anything major will be worked on this version which we're all experiencing issues with, as I suspect any action will take the resources away from Brave Rewards which I anticipate to be far more effective and functional.

Think of it like this, we're going to most likely experience a far better Brave in less time than the next expiry date of funds or possibly the next contribution date.

BobT36 commented 6 years ago

@NumDeP Uh is "Brave-Laptop-Moun" the current desktop version? And I presume "Brave-Browser-Core" is the in-dev one? Not really kept track of it sorry.

And my funds first start expiring in 6 days...

kjozwiak commented 6 years ago

@BobT36 & @jacobrosenthal,

Could you please PM your paymentId using Brave Community? Here's my username that you can PM:

You can retrieve you're paymentId from the following locations:

Should look something like the following:

      },
      "paymentId": "014f077e-f6ca-467d-adf8-d4de042bae0b",
      "addresses": {
        "BAT": "0x0f054F834cbeF78A1F1E07286E36364dd14836be",
        "BTC": "1AHc5819BSQUbt9LGdh9HFEa2Xo84e5Zi1",
        "CARD_ID": "5497a4ab-358b-4f30-86dc-5d182a7e4126",
        "ETH": "0x0f054F834cbeF78A1F1E07286E36364dd14836be",
        "LTC": "LRjpnJzAnq8NdpFLvWbd1sAjrSkVZMqMAU"
      }

Once we get the paymentId, we'll take a look and see if we can figure out what's going on with your wallets 👍

BobT36 commented 6 years ago

Done, thanks! Happy to assist otherwise.

BobT36 commented 6 years ago

Well, it's now started expiring lol..

I'm now 35 BAT down. Gone, expired, not sent or anything: capture

NumDeP commented 6 years ago

I was completely cleaned out and it didn't contribute to any of the publishers as well. Pity I couldn't backup the BATs onto Brave-Cores's Rewards. Still at least they were kind enough to give us the BATs to test it out.

@BobT36 They've go a server issue and a couple of UI/UX related bugs in Rewards but I'm pretty sure after those are fixed, the system would be more stable than any of us have ever experienced.