search

brennanpincardiff / drawProteins

Creating package to draw proteins from Uniprot API
Other
33 stars 17 forks source link

Adding transparency option to the draw* functions #31

Closed stevin-wilson closed 2 years ago

stevin-wilson commented 2 years ago

Hi Dr. Brennan

Thank you so much for the wonderful package. I have modified the geoms.R script to include an alpha option in the draw* functions to control the transparency of the geom_rect elements.

Please let me know if any additional information is required.

Thank you

Sincerely, Stevin

brennanpincardiff commented 2 years ago

Thanks Stevin, I've merged your changes. This seems like a nice addition. Would you be willing to write a script that shows how this works, please? We could post this here and potentially include it in other places too... Perhaps my blog, perhaps we can aim for something for Bioconductor.. What do you think? Best wishes, Paul

stevin-wilson commented 2 years ago

Hi Paul

Thank you for merging the changes. I will write an Rmarkdown file to show how the ‘alpha’ parameter can be used for the diagrams. I am aiming to get it ready by the end of this weekend.

Thank you

Sincerely, Stevin

STEVIN WILSON, PhD BIOINFORMATICIAN Clemson University Genomics and Bioinformatics Facility

190 Collings Street Office 160H Clemson, SC 29634 c 614-377-4897 @.**@.>

[signature_772141729]

From: Paul Brennan @.> Date: Wednesday, September 15, 2021 at 7:12 AM To: brennanpincardiff/drawProteins @.> Cc: Stevin Wilson @.>, Author @.> Subject: Re: [brennanpincardiff/drawProteins] Adding transparency option to the draw* functions (#31)

Thanks Stevin, I've merged your changes. This seems like a nice addition. Would you be willing to write a script that shows how this works, please? We could post this here and potentially include it in other places too... Perhaps my blog, perhaps we can aim for something for Bioconductor.. What do you think? Best wishes, Paul

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/brennanpincardiff/drawProteins/pull/31#issuecomment-919925281, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANIG64XWXCLSSPPPU4DXBULUCB5QBANCNFSM5D2SIFGA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.