search

brenoguim / flexclass

A library for classes with flexible layout
MIT License
56 stars 6 forks source link

Add performance verification test #13

Open brenoguim opened 4 years ago

brenoguim commented 4 years ago

The library contains a benchmark directory with a single benchmark. It would be nice to have a check that the performance using the library is actually better than the performance without it.

Not sure how to implement that. People with experience in Catch2 and cmake wanted :)

eullerborges commented 4 years ago

I don't have experience with performance benchmarking in Catch2, but I've used it before with cmake. I'll look into what people normally do in those cases.

eullerborges commented 4 years ago

It looks like that comparing the performance with only Catch2 isn't possible. It does seem though that Github Actions has support for Catch2 and performance tracking. What if we use that for performance regression testing?

I managed to build the tests with the performance test, but I couldn't quite understand if we're testing it here somehow. I see that without the -r junit to show the full textual output we get the times for each of the subsections. Are we somehow verifying that?

brenoguim commented 4 years ago

When you build the performance test it will run with the regular tests but no check is really being done. I usually manually run the binary to see the output.

So it's all very brittle today. I like the idea from the link of keeping reference performance numbers and compare against that!