Closed eullerborges closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
master@6c66593
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
Coverage ? 96.42%
=========================================
Files ? 1
Lines ? 196
Branches ? 0
=========================================
Hits ? 189
Misses ? 7
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c66593...a83621f. Read the comment docs.
The CMakeLists.txt is a bit on the hacky side since I couldn't find a better way to instruct CMake to generate a preprocessed file. Note that with this code, this check won't ever work for the Visual Studio compiler as the syntax for preprocessing with it is a bit different.
I think that is fine. Perhaps we can disable/adjust that for visual studio when time comes to support that.
This includes a job in the default CMake GitHub Action to allow us to check the preprocessed size for every push.
The
CMakeLists.txt
is a bit on the hacky side since I couldn't find a better way to instruct CMake to generate a preprocessed file. Note that with this code, this check won't ever work for the Visual Studio compiler as the syntax for preprocessing with it is a bit different.I've tested this to work properly in my fork. Today the preprocessed library has 3558 lines (on both
Debug
andRelease
) which is why I've set the limit to 4500 lines, following a similar reasoning as that of the time of writing of #12.