search

brey / pyPoseidon

Framework for hydrodynamic simulations of geoflows
https://pyposeidon.readthedocs.io/
European Union Public License 1.2
7 stars 8 forks source link

customizing the names of longitude and latitude of the input nc file, plus minor fixes #15

Closed menta78 closed 4 years ago

menta78 commented 5 years ago

Currently the static method to_force of the schism class assumes that the coordinates in the nc input file are named longitude and latitude. I added a kw argument coordvars, that allows to override this assumption.

The pull requests also includes other minor fixes.

brey commented 4 years ago

@menta78 Thanks for the input. A few comments.

Regarding the logging.config, there seems not to be an issue and I would prefer to keep the import at the top level to make the code below more transparent.

There have been some changes on the meteo.py regarding that kwargs. Please do a pull to check. Regarding the option to name variables and coordinates, there is general question. So far, I have elected to rename them (see pynio & from_url functions). This way there to_force() is simplified and there is also a higher level of abstraction which make comparison much easier. This functionality was missing from the plain netcdf function, thus the issue with your input. I will update it accordingly and include a test as well.