search

brey / pyPoseidon

Framework for hydrodynamic simulations of geoflows
https://pyposeidon.readthedocs.io/
European Union Public License 1.2
7 stars 8 forks source link

tests: Move tests to the outer directory #23

Closed pmav99 closed 3 years ago

pmav99 commented 4 years ago

The best python framework is pytest. In order to make usage of its test runner the test suite should be structured according to its own conventions (which we already do).

Nevertheless, it is also a good idea to keep the test suite outside the proper package (docs). Among other things, this makes it easier to grep the source code. E.g.

# search for `ncores` in `pyPoseidon` and `tests` respectively.
ag ncores pyPoseidon
ag ncores tests

I will make a pull request that moves the tests to a separate tests directory. @brey even if the CI passes do not merge this before making sure that you don't have changes in the tests in your local repo. If you do merge it you will have to deal with the conflicts afterwards.

brey commented 3 years ago

Now with the new tagged release, I guess it is a good time to do this.