search

brianc / jade-mode

Emacs major mode for jade template highlighting
MIT License
157 stars 42 forks source link

Named regexes, cask integration, more tests #56

Closed MC-Escherichia closed 8 years ago

MC-Escherichia commented 8 years ago

I did all this work to figure out the simple syntax issue for mixin highlighting, but I think it will aid others in future development.

brianc commented 8 years ago

@tjefferson08 has been maintaining this repo lately - I don't use emacs anymore. I'm happy to merge this if you think it's good, but I'm flying pretty blind to be honest.

tjefferson08 commented 8 years ago

Oh! @brianc I reached out to @MC-Escherichia via email but neglected to follow up on the GH issue here.

I think the PR looks great, I just wanted to pull down the changes and check them locally before merging. It's on my list for tomorrow! :) Thanks for the patience.

brianc commented 8 years ago

No problemo! Keep on keepin' on! Feel free to ping me if you need anything. :)

tjefferson08 commented 8 years ago

In the interest of productivity, I'm going to merge! I'll take care of the issues I pointed out in the review in a follow-up PR. Thanks a million for the contribution, @MC-Escherichia! Keep 'em coming