search

brianch / offline-chess-puzzles

Tool to view and solve puzzles from the lichess puzzle database
MIT License
115 stars 16 forks source link

vcruntime140.dll needed in win7 and on win10 the labels sometimes are not shown correctly #3

Closed Shine0717 closed 1 year ago

Shine0717 commented 2 years ago

Congratulations Brianch has released the new version!

Since the last version was released, I have checked it out almost every day. Whenever I see the "code" page, it shows modified "a few hours, or days", I am very excited. Thank you very much for your hard work, Brianch.

After version of 2.0, I've been a little busy at work this month, so I didn't play it very often.

I tried it on the win7, and it noticed me that a 'VCRUNTIME140.dll' file is missing. I guess its my computer's problem.

But when I tried it on win10 system, sometimes there are strange "patterns" on the screen. I don't know if this is my computer's problem. Anyway it's not a big problem, you don't need to fix it in hurry. strange

brianch commented 2 years ago

Hi,

About VCRUNTIME140.dll, is this the exact same computer where the older version worked fine? If so, I might have made the mistake of, while building the exe, not including the config option that would embed the needed functions from this library and avoid users having to install it.

Unfortunately I won't have time to create a new file in a while (it would probably be simple in normal conditions but working in a VM is extremely slow), but you can easily install the library from Microsoft's download page: https://www.microsoft.com/en-us/download/details.aspx?id=52685 (the x64 file is 64 bits and the x86 is 32 bits)

If you do, please tell if it fixed the issue or not. If it does I will mention it in the release notes as a known issue.

About the problem on Windows 10, can you provide some more info?:

  1. You said it happens "sometimes", how often is it? Is it totally at random or related to something else?
  2. What square size are you using? I noticed it seems to be bigger than the larger value I tested (90), because the queen promotion image is squeezed there. If you resize the window manually, is the text still shown in that weird way?
  3. Does the "windows 7" version has this same problem when tested in this Windows 10 computer?
  4. Take a look if your graphics card drivers are updated if possible.

Thanks for reporting.

brianch commented 2 years ago

(I changed the title just for it to be more descriptive, and make it easier for others to see what it's about)

Shine0717 commented 2 years ago

Hi Brianch,

  1. Recently it was working alright, I guess it was my computer's problem.
  2. I set the value 90 (under 1920*1080)
  3. Since the new vision cannot run in Win7(VCRUNTIME140.dll error), I haven't test it yet.
  4. I have just updated my GPU driver, but it still happen.

I don't think you need to fix anything, we'll get to used it.

brianch commented 2 years ago

Hi!

So the visual glitch isn't happening anymore at all? I'm a bit confused with the answers for the 1st and 4th questions, because in the 4th one you said it still happens.

In the current code, the promotion piece images should be ok now with a 90 square size (after commit 344386855625ca1afa380870a7f9aa0e0efce244) but I guess I could increase it horizontally even more actually.

And yes, I understood that it isn't running in windows 7, I was asking if the "offline-chess-puzzles-w7-64bits.exe" works well in Windows 10 instead. By the way, you can't install that Microsoft library in the windows 7 computer?

In the future I should use a CI/CD tool to build the Windows binaries, I don't even have the Windows virtual machine to do it anymore because I was running out of hard drive space.

Shine0717 commented 2 years ago

Hi, Brianch.

I've just tested the win7 version, after following your instruction that downloaded the library from Microsoft's website, it's working alright.

And there's no any visual glitch occurred(window size:75, under 1366x768).

I suggest please don't close this "issue", because the download link that you provided is very useful. Some users who occur this problem may need this.

When I go back to my win10 computer, I'll try it again, and let you know whether the visual glitch problem still occur after I use a new GPU(RTX 2060).

brianch commented 1 year ago

Since there was no further report about the labels issue, and the vcruntime thing should be fixed now after the last few changes on the github actions workflow, I'm gonna close this.