search

brianedwardsaunders / sfdx-ext

sfdx extension
MIT License
15 stars 5 forks source link

Unmet peer dependency #4

Closed acrosman closed 4 years ago

acrosman commented 4 years ago

When installing on Windows 10 in PowerShell I get an unmet peer dependency warning. This does not appear to effect the function of the plugin or the rest of SFDX operation.

> sfdx plugins:install sfdx-ext                                                                                                     
This plugin is not digitally signed and its authenticity cannot be verified. Continue installation y/n?: y
Finished digital signature check.
warning sfdx-ext > @salesforce/core > @salesforce/ts-sinon > sinon > @sinonjs/formatio > samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam
warning "sfdx-ext > @oclif/command@1.5.19" has unmet peer dependency "@oclif/plugin-help@^2".
Installing plugin sfdx-ext... installed v0.0.33
brianedwardsaunders commented 4 years ago

Hi

I haven't tested this in powershell. Only cmd (windows) and bash (Unix).

Will look into it.

Regards

On Tue, Feb 4, 2020, 21:06 Aaron Crosman notifications@github.com wrote:

When installing on Windows 10 in PowerShell I get an unmet peer dependency warning. This does not appear to effect the function of the plugin or the rest of SFDX operation.

sfdx plugins:install sfdx-ext This plugin is not digitally signed and its authenticity cannot be verified. Continue installation y/n?: y Finished digital signature check. warning sfdx-ext > @salesforce/core > @salesforce/ts-sinon > sinon > @sinonjs/formatio > samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam warning "sfdx-ext > @oclif/command@1.5.19" has unmet peer dependency "@oclif/plugin-help@^2". Installing plugin sfdx-ext... installed v0.0.33

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/brianedwardsaunders/sfdx-ext/issues/4?email_source=notifications&email_token=AC7TR3B3LQGU3TAQ4CFPQ2DRBG4BVA5CNFSM4KP4I4Y2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IK7V4BA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7TR3DTHPNECXPVJBAXTFDRBG4BVANCNFSM4KP4I4YQ .

acrosman commented 4 years ago

For what it's worth I just re-ran it in cmd with more or less the same results:

C:\Users\ahcrosman>sfdx plugins:uninstall sfdx-ext
Uninstalling sfdx-ext... done

C:\Users\ahcrosman>sfdx plugin:install sfdx-ext
 »   Warning: plugin:install is not a sfdx command.
Did you mean plugins:install? [y/n]: y
This plugin is not digitally signed and its authenticity cannot be verified. Continue installation y/n?: y
Finished digital signature check.
warning sfdx-ext > @salesforce/core > @salesforce/ts-sinon > sinon > @sinonjs/formatio > samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam
warning "sfdx-ext > @oclif/command@1.5.19" has unmet peer dependency "@oclif/plugin-help@^2".
Installing plugin sfdx-ext... installed v0.0.33

Also, I should add: this is a great extension and much appreciated.

brianedwardsaunders commented 4 years ago

Hi Aaron

Update: I had a look at this warning this morning, there appears to be a deprecated library dependency in the salesforce command library (which I am dependant on, and am using the latest version ^2.2.0)

Warning message: npm WARN deprecated samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam

Trace: (THIS IS THE WARNING TRACE) warning @salesforce/command > @salesforce/core > @salesforce/ts-sinon > sinon > @sinonjs/formatio > samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam

I did a npm audit and there are no vulnerabilities reported, so technically plugin should still be safe to use.

8 packages are looking for funding run npm fund for details

found 0 vulnerabilities

conclusion and next steps:

I will log an issue with the @salesforce/command and alert them of warning. At this stage its a warning and the sfdx:ext plugin should still work.

Thanks for your feedback. I will periodically keep checking the @salesforce libraries for updates.

Steps followed below:

C:\code\company>npm i --g sfdx-ext npm WARN deprecated samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam

C:\code\company>sfdx plugins:uninstall sfdx-ext Uninstalling sfdx-ext... done

C:\code\company>sfdx plugin:install sfdx-ext » Warning: plugin:install is not a sfdx command. Did you mean plugins:install? [y/n]: y This plugin is not digitally signed and its authenticity cannot be verified. Continue installation y/n?: y Finished digital signature check. warning "@salesforce/lwc-dev-server > @webruntime/compiler > @lwc/rollup-plugin@1.0.2-222.18" has incorrect peer dependency "@lwc/engine@1.0.x". Installing plugin sfdx-ext... installed v0.0.36

C:\code\company>sfdx ext --help Activate or deactivate all flows (i.e. flows and process builders whilst maintaining latest version).

USAGE $ sfdx ext:COMMAND

COMMANDS

TOPICS Run help for each topic below to view subcommands

ext:flows Activate or deactivate all flows (i.e. flows and process builders whilst maintaining latest version). ext:mdapi Generates a detailed changeset by comparing differences between two mdapi staged source directory files or source control commit versions. ext:package Compare package versions between two orgs and/or sync (install or uninstall) packages in target org based on package version(s) in the source org. This command needs to be run from within project folder (sfdx dependancy). ext:source Convert from sfdx to mdapi src (and update target src package.xml files).

On Wed, 5 Feb 2020 at 02:51, Aaron Crosman notifications@github.com wrote:

For what it's worth I just re-ran it in cmd with more or less the same results:

C:\Users\ahcrosman>sfdx plugins:uninstall sfdx-ext

Uninstalling sfdx-ext... done

C:\Users\ahcrosman>sfdx plugin:install sfdx-ext

» Warning: plugin:install is not a sfdx command.

Did you mean plugins:install? [y/n]: y

This plugin is not digitally signed and its authenticity cannot be verified. Continue installation y/n?: y

Finished digital signature check.

warning sfdx-ext > @salesforce/core > @salesforce/ts-sinon > sinon > @sinonjs/formatio > samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam

warning "sfdx-ext > @oclif/command@1.5.19" has unmet peer dependency "@oclif/plugin-help@^2".

Installing plugin sfdx-ext... installed v0.0.33

Also, I should add: this is a great extension and much appreciated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianedwardsaunders/sfdx-ext/issues/4?email_source=notifications&email_token=AC7TR3EYPCWB3J3C7QNU643RBIEPRA5CNFSM4KP4I4Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZX7AI#issuecomment-582188929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7TR3CWST5DSNCKESHIJ5DRBIEPRANCNFSM4KP4I4YQ .

-- Regards Brian Saunders

acrosman commented 4 years ago

The first warning is definitely from core and just popped up the other day so I figured they would catch it in the next release (or so).

The second peer dependency issue is what I'm chancing: warning "sfdx-ext > @oclif/command@1.5.19" has unmet peer dependency "@oclif/plugin-help@^2".

Any chance you have that installed globally or something related to doing the development of the plugin itself. I'm seeing it in a second plugin as well so my gut is that it's something bubbling up from the requirements of creating a plugin that isn't triggered by developers cause they picked up the library some other way.

acrosman commented 4 years ago

Once I said it, I was able to come up with a guess.

I think if you moved the @oclif/plugin-help@^2 from being a dev dependency to a regular dependency in the package.json file it would fix it.

I can send you a PR if you'd like.

brianedwardsaunders commented 4 years ago

Ok cool thanks

On Wed, Feb 5, 2020, 16:36 Aaron Crosman notifications@github.com wrote:

Once I said it, I was able to come up with a guess.

I think if you moved the @oclif/plugin-help@^2 from being a dev dependency to a regular dependency in the package.json file it would fix it.

I can send you a PR if you'd like.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianedwardsaunders/sfdx-ext/issues/4?email_source=notifications&email_token=AC7TR3FI4NVJU5AXWIWRGP3RBLFITA5CNFSM4KP4I4Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK3UUVI#issuecomment-582437461, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7TR3FHKRHOFN2ULGSY4ETRBLFITANCNFSM4KP4I4YQ .

brianedwardsaunders commented 4 years ago

I am not comfortable changing this item's position ( @oclif/plugin-help@^2 ) as this is setup as part of the standard sfdx plugging create cli.

After updating all the dependencies. I am seeing there is still some instability between sfdx npm release versions. (fortunately only warnings and not errors).

I have updated global cli

C:\code\company>npm install -g sfdx-cli

npm WARN deprecated samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsamnpm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3. C:\Users\brian.saunders\AppData\Roaming\npm\sfdx -> C:\Users\brian.saunders\AppData\Roaming\npm\node_modules\sfdx-cli\bin\run

I globally install C:\code\company>npm install -g sfdx-ext npm WARN deprecated samsam@1.3.0: This package has been deprecated in favour of @sinonjs/samsam

I install sfdx-ext plugin to sfdx

C:\code\company>sfdx plugins:install sfdx-ext This plugin is not digitally signed and its authenticity cannot be verified. Continue installation y/n?: y Finished digital signature check. warning "@salesforce/lwc-dev-server > @webruntime/compiler > @lwc/rollup-plugin@1.0.2-222.18" has incorrect peer dependency "@lwc/engine@1.0.x". Installing plugin sfdx-ext... installed v0.0.38

I will keep monitoring the situation but for now, this is, unfortunately, all the time I can spend on this.

I suspect these warnings will be resolved in future.

Regards Brian

On Wed, 5 Feb 2020 at 16:36, Aaron Crosman notifications@github.com wrote:

Once I said it, I was able to come up with a guess.

I think if you moved the @oclif/plugin-help@^2 from being a dev dependency to a regular dependency in the package.json file it would fix it.

I can send you a PR if you'd like.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianedwardsaunders/sfdx-ext/issues/4?email_source=notifications&email_token=AC7TR3FI4NVJU5AXWIWRGP3RBLFITA5CNFSM4KP4I4Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK3UUVI#issuecomment-582437461, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7TR3FHKRHOFN2ULGSY4ETRBLFITANCNFSM4KP4I4YQ .

-- Regards Brian Saunders

acrosman commented 4 years ago

I think the instructions that have folks putting the oclif/plugin-help dependency in dev instead of as a standard dependency are either out of date or weren't tested by deployments instead of just developers. PR #5 is pretty simple and moves the dependency into the proper place.

brianedwardsaunders commented 4 years ago

Updated in v0.0.40