brianfoshee / aquaponics-data

0 stars 0 forks source link

Modify panic(err) in GetReadings to return JSON compliant error message #14

Closed nathanprayzo closed 9 years ago

brianfoshee commented 9 years ago

Is this a duplicate of #13 or are they for the main.go func and the db.Manager func? Maybe we should rename the function in main.go to avoid naming confusion.

nathanprayzo commented 9 years ago

One is for main.go and the other is for db.Manager func.

I will create a separate issue to rename the function in main.go to avoid naming confusion.

nathanprayzo commented 9 years ago

The db.Manager GetReadings func doesn't have access to the response writer so I moved the check for negative or zero number of requests to the getReadings http handler. As such this issue is no longer relevant.