brownfield-team / anacapa-github-linker

A tool for managing students in computer science courses. Deployed at:
https://ucsb-cs-github-linker.herokuapp.com
MIT License
4 stars 6 forks source link

[Bug] When course has no team info yet, the GitHub teams page shows "Loading..." indefinitely #434

Closed pconrad closed 3 years ago

pconrad commented 3 years ago

Expected Behavior

When course has no team info yet, the GitHub teams page shows "Loading..." indefinitely

This is confusing, because it will never change. Instead, if there is no data, it should display something llike "No Data", and ideally, give the user an instruction and a button to run the job that loads the teams from GitHub.

Similarly, once you add the teams, if there are no project repos, you get "Loading..." indefinitely, which is also misleading. Instead, it should say something like "no repos", and give you the button to run the "refresh repos" job.

There may be a similar issue when there are no project repos defined.

Current Behavior

See above

Steps to Reproduce

On a brand new course, or after manually deleting all of the records for Github Teams (which are called OrgTeams in the database, I think), go to the GitHub Teams page in the UI. You will see the "Loading..." message.

Possible Solution

Check if the API has returned with an empty list, vs. the empty list that is present when the page first loads and the API call hasn't returned yet. We need to distinguish between these two cases.