As an instructor I can add additional instructors to a course so that multiple users can have instructor access to a course

[pconrad]

User Story (Epic)

• As an instructor
• I can add additional instructors to a course
• So that multiple users can have instructor access to a course

Fine grained user stories

1. As a developer, there is a react component I can use to list multiple instructors for a course so that I have an easy way to display multiple instructors for a course, seeing name and email address.
2. As a user, on any course where I have access to the course page, I can see a list of the instructors for that course right under the name of the course, so that I know who the instructors are for the course.
3. As a developer, there is a method

Acceptance Criteria

• [ ] There should be a way to list all instructors for a course (this could be factored out into it's own story, and tested by manually adding additional instructors via the rails console (rails c) for testing purposes.
• [ ] All instructors (including the one that created the course) should have full instructor permissions on the course; the "first instructor" (the one that created it) should not be a special case. (Look for code that does a .first when looking up the instructor for a course, or methods that return "the" instructor for a course, and change them so that they return a list of instructors. Make sure consumers of those methods process the return value correctly.)
• [ ] There should be method on the course model object to add an instructor. It will be up to the implementor to decide whether it makes more sense to take email address or user id as a parameter; probably user id, since detailed error handling (e.g. if the email address doesn't exist) should perhaps be handled in controller logic? But that's up to the implementor; the only thing for sure is that error handling needs to be considered.
• [ ] There should be a way in the UI for an instructor (on the course) or any admin to add an additional instructors to a course by entering the users email address. Incorrect email addresses need to be handled gracefully.
• [ ] In the first cut, it is ok if there is not a way to remove an instructor; that can be a separate story.

...

Implementation Todos

Back end:

• [ ] Add a method (or refactor an existing method) on the course model object to list all instructors of a course (e.g. @course.instructors)
• [ ] Add an api method to list all instructors of a course (e.g. by returning the value of @course.instructors as JSON.)
• [ ] Create an api method to add an instructor to a course. It should be available only to admins, and current instructors of the course. It should consume the email address of a user, look up that user in the users database, and add that user as an instructor of the course. Note that the user may or may not be an "instructor" in the sense that they have the capability to create other courses; we need to review how the "roles" work in this instance.

Front end:

• [ ] Add a react component that lists all instructors of a course; it should just take the list of instructors as a parameter (and for the time being, have no interaction with the backend api. This could be factored out into it's own story, with jest tests and a storybook entry.)
• [ ] Incorporate that react component ...

Testing:

• [ ] Jest coverage for all new react components added
• [ ] if possible, minitest Rails coverage for all rails methods touched

[pconrad]

It appears that models/course.rb has a method called instructor.

We probably want to remove that method and replace it with one called instructors.

The .instructor method appears to be used in only one place, which is in this code inside models/user.rb... here's that code with a comment that suggests what the replacement code might look like. I'm not sure if include? is a legitimate method here, but it's at least correct as pseudocode...

[pconrad]

Another implementation suggestion:

The first step might be to go to app/views/courses/_show_admin.html.erb and add a React Component at the top of the page called CourseInfo. That component could at first just take a @course object, and perhaps also a list of the instructors, and it would render a table showing for each instructor, just their name and their email address.

Later on, all the other stuff that's in the header of the course page could be moved into the React component as well.

[pconrad]

As a remidner, when you create a new react component that you are going to insert into an .erb file with react_component, you have to register it inside this file:

app/javascript/packs/react-bundle.js