brownplt / pyret-docs

The documentation for Pyret.
9 stars 18 forks source link

Possible Type in string-dict documentation #25

Closed murrayLuke closed 6 years ago

murrayLuke commented 6 years ago

Possible typo on the following line.

https://github.com/brownplt/pyret-docs/blob/3d9cf6f5a7bd73a51aa43a8d3d25db4071a4e980/src/trove/string-dict.scrbl#L249

Maybe this should return a mutable string dict?

The current line returns a String Dict (SD-of "a") @collection-doc["mutable-string-dict" #:contract `(a-arrow ("elt" "a") ,(SD-of "a"))]

I think the correct line would be the following but I may be incorrect!

@collection-doc["mutable-string-dict" #:contract `(a-arrow ("elt" "a") ,(MSD-of "a"))]

jpolitz commented 6 years ago

Fixed, thanks!

On Sat, Sep 30, 2017 at 11:08 AM, Luke Murray notifications@github.com wrote:

Possible typo on the following line.

https://github.com/brownplt/pyret-docs/blob/3d9cf6f5a7bd73a51aa43a8d3d25db 4071a4e980/src/trove/string-dict.scrbl#L249

Maybe this should return a mutable string dict?

The current line returns a String Dict (SD-of "a") @collection-doc["mutable-string-dict" #:contract `(a-arrow ("elt" "a") ,(SD-of "a"))]

I think the correct line would be the following but I may be incorrect!

@collection-doc["mutable-string-dict" #:contract `(a-arrow ("elt" "a") ,(MSD-of "a"))]

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/brownplt/pyret-docs/issues/25, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHUU5ZTuKiexQHsFHAeBjBH3kBP4fBLks5snoO7gaJpZM4PppIu .