brownplt / pyret-docs

The documentation for Pyret.
9 stars 18 forks source link

Add a basic search page #40

Closed sorawee closed 6 years ago

sorawee commented 6 years ago

This commit hacks the glossary page to be a search result page in the same time. Note that Scribble has a functionality to propagate query strings via links, but this would interact badly with this new feature, so we need to explicitly patch it.

sorawee commented 6 years ago

Screenshot:

2018-08-02-063714_1033x893_scrot

blerner commented 6 years ago

I'd tweak this slightly to add:

Showing results only for: "app"
[x] Clear search filter

and clicking the "Clear" link would take you to the Glossary page, without any query terms...

sorawee commented 6 years ago

peek 2018-08-02 17-26

@blerner @shriram is this OK?

Note that the GIF freezes for about 10 seconds in the beginning, but there's nothing interesting there (just to show that the search box will link to the glossary page)

sorawee commented 6 years ago

Screetshot (just in case you can't view the GIF)

2018-08-02-174414_996x920_scrot

shriram commented 6 years ago

Yes, wow!