Closed shriram closed 4 years ago
bitmap-url
was removed in the new image library. As far as I recall, we had agreed to remove it since it was redundant with image-url
. https://github.com/brownplt/pyret-lang/issues/308#issuecomment-309215912 indicates we should have kept it; but https://github.com/brownplt/pyret-lang/issues/417#issuecomment-353062193 a few months later indicates we should remove it.
Either we should add this back (in which case this is a CPO bug and should transfer there), or we should update the docs (in which case this is a docs bug and should transfer there).
Docs bug. We agreed to remove it quite some time ago. The Bootstrap teachpack has already been updated for backwards compatibility.
This almost certainly breaks reactive programs, but I honestly don’t think there are enough users out there to justify keeping this in the language at this point
@blerner A quick search shows https://github.com/brownplt/code.pyret.org/blob/383237365f2b87d517dcbbb1a04b0d17f41dd763/src/web/js/trove/make-image.js#L158 to me. Is it a dead code?
Effectively yes. It does seem to create the function, but it's not part of image module's exported definitions.
On Fri, Aug 21, 2020, 3:14 PM sorawee notifications@github.com wrote:
@blerner https://github.com/blerner A quick search shows https://github.com/brownplt/code.pyret.org/blob/383237365f2b87d517dcbbb1a04b0d17f41dd763/src/web/js/trove/make-image.js#L158 to me. Is it a dead code?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brownplt/pyret-docs/issues/56#issuecomment-678448739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHAHQCLIOKK2LFUSDLV2PDSB3BQLANCNFSM4QHRMBIA .
Docs say it's there
https://www.pyret.org/docs/latest/image.html#%28part._image_bitmap-url%29
but CPO says it's not.
Tara claims it worked for her a few minutes ago; she brought her laptop down; and said it was no longer working. That's really weird, but also, if it weren't bound at all, I don't know how her code could have worked. Confused.
But setting that aside, there seems to be an inconsistency between docs and code.
image-url
works fine.