search

browserify / browser-resolve

resolve function which support the browser field in package.json
MIT License
102 stars 70 forks source link

Synchronous API #34

Closed tarruda closed 10 years ago

tarruda commented 10 years ago

Not sure if this is useful for you, but I needed in another project so I implemented an API similar to 'node-resolve', refactoring as much as I could for code reuse.

The biggest difference in this patch is that it adds a 'sync' function which does the resolution synchronously. I refactored all tests into 'describes' with a sync version for each.

defunctzombie commented 10 years ago

The following need to be fixed before I can merge this.

You changed tests to describe. I specifically want to use qunit/tdd style not describe. Please put back that style with your new tests.

Also given that the change Implement synchronous API change moves to new files and introduces changes to those files it makes it impossible to review the diff. Could you please first make a commit which moves the existing code to new files, unchanged and tests passing. Then add your sync api additions and tests.

I am also ok with the export same API commit. That one is fine.

Thanks.

defunctzombie commented 10 years ago

Closing for lack of activity.