search

browserify / browser-resolve

resolve function which support the browser field in package.json
MIT License
102 stars 70 forks source link

global leak error detected in mocha #63

Closed benpptung closed 9 years ago

benpptung commented 9 years ago

While doing unit test to upgrade browserify module, I keep to get global leak error, which is introduced due to the following line. I am sorry I see no reason why the replacements variable should be defined in global object. Should it be fixed??

https://github.com/defunctzombie/node-browser-resolve/blob/master/index.js#L37

defunctzombie commented 9 years ago

seems like a bug/oversight