search

brucemiller / LaTeXML

LaTeXML: a TeX and LaTeX to XML/HTML/ePub/MathML translator.
http://dlmf.nist.gov/LaTeXML/
Other
961 stars 101 forks source link

Itemize fixes #2211

Closed brucemiller closed 1 year ago

brucemiller commented 1 year ago

This PR fixes several itemization issues

Fixes #1645 Fixes #1927 Fixes #1961 Fixes #2155

dfrankow commented 1 year ago

I applaud your energy to maintain a valuable package that requires so much work.

I am a little surprised to see no test cases associated with this PR. Maybe I'm missing something?

It seems really hard (I'd say impossible) to preserve such subtle behavior without test cases.

Anyway, best wishes.

dginev commented 1 year ago

It seems really hard (I'd say impossible) to preserve such subtle behavior without test cases.

That is a fair point in general @dfrankow , and I often tend to harp on that tune in PR reviews. Here I took the update to t/keyval/keyvalstyle.xml as a sufficient minimal proof that we have at least one test tracking the changes - but it is clearly partial.

Some of the original snippets in the reported issues could be converted into small tests, if we had a subtlety we thought was particularly fragile - does one come to mind here?