search

brummer10 / guitarix.vst

guitarix vst3 wrapper for linux
62 stars 1 forks source link

A cabinet type change doesn't take effect until the cabinet simulator is reloaded #7

Closed Gimmeapill closed 1 year ago

Gimmeapill commented 1 year ago

A change of cabinet doesn't take effect immediately: the cabinet module needs to be deactivated/reactivated for the change to be applied. This looks like a defect compared to the behavior of Guitarix standalone.

brummer10 commented 1 year ago

Strange, I can't reproduce this one. Does it as well happen in Carla?

Gimmeapill commented 1 year ago

It does. I tried also in Renoise & with Carla, the behavior is the same: a cabinet type change has no effect until the module is muted/unmuted, then the change takes effect

kramlie commented 1 year ago

I can reproduce this as well.

kramlie commented 1 year ago

Btw, I just noticed that this also happens with the Presence knob on the Amp Stack. You have to turn Presence off and on again for the knob to have any effect.

Gimmeapill commented 1 year ago

Confirmed as well for the Presence knob. I tried the other controls and didn't find more issues so far.

brummer10 commented 1 year ago

Really strange. Works here as it should. Could you try to build the juce standalone version (make Standalone) and checkout if there is the same issue? Just start the standalone from top source dir after build /Builds/LinuxMakefile/build/Guitarix

Note, this version is not meant to be distributed

kramlie commented 1 year ago

Yes, the standalone version has the same issue.

I could try to debug it, though I would appreciate a pointer on where to start / variables to keep an eye on, since the source code is huge and I'm not super familiar with it.

Gimmeapill commented 1 year ago

Yes, exactly the same behavior with the standalone version.

brummer10 commented 1 year ago

Okay, I found it. I could reproduce it here now as well. A fix will come with the next push, I just need to do some clean-ups.

brummer10 commented 1 year ago

The fix is pushed to the repository. It should work now. Additional I've implemented a File-browser for the convolvers, so that you could load now your own IR-files directly in the vst plugin.

kramlie commented 1 year ago

You're right, it has improved, but it still doesn't work quite right in stereo mode. It's like one side gets the update, but not the other, or something like that. Applies to both the Cabinet and Presence.

brummer10 commented 1 year ago

Yep, forgotten the stereo mode check, it's implemented now. Thanks for keeping attention on that.

kramlie commented 1 year ago

Confirmed working for both controls! Thank you!!

You can close this issue as far as I'm concerned (I don't have permission).

brummer10 commented 1 year ago

@Gimmeapill Do you confirm as well?

Gimmeapill commented 1 year ago

I do - closing