search

brunch / brunch

:fork_and_knife: Web applications made easy. Since 2011.
https://brunch.io
MIT License
6.81k stars 436 forks source link

⚠️ Stripping trailing slash before matching conventions. #1891

Closed seanmorris closed 1 year ago

seanmorris commented 1 year ago

https://github.com/brunch/brunch/issues/1890

It seems that anymatch 3.1.3 no longer automatically strips trailing slashes from paths before matching. This PR handles the stripping of the trailing slash before the match operation occurs.

Brunch won't work with new versions of anymatch without these changes, and the current package.json will not prevent new projects from pulling anymatch 3.1.3+. Thus nothing will work for new users until this is fixed.

Also, without this patch, npm update will break existing projects. This break may be silent as the index.html and other assets may already be built. They will NOT be correctly rebuilt without this patch. Furthermore, any CI/CD that depends on spinning this up from scratch will fail.

This patch seems to play nice with anymatch 3.1.1 and 3.1.2.

paulmillr commented 1 year ago

a20d6a2997da1a192bed80f6d1f3fc2815196692