search

brunch / stylus-brunch

Adds Stylus support to Brunch
MIT License
21 stars 2 forks source link

Recursive dependencies #16

Closed germanrio closed 11 years ago

germanrio commented 11 years ago

Usually when using stylus, there is a main file e.g. app.styl that imports another files like _header.styl, _footer.styl,... These two files are dependencies of the former one, so when one of this files changes, brunch watch recompile app.styl.

The problem comes when one of this dependencies has another dependency. For example, imagine that _header.styl imports _menu.styl. In this case, if _menu.styl changes, app.styl is not recompiled by brunch watch.

This only happens with dependencies which are ignored by brunch, this is, the files starting with _. But this is the quite usual, that's why I've made this request that solves this problem.

paulmillr commented 11 years ago

needs rebasing

germanrio commented 11 years ago

Rebase done.

paulmillr commented 11 years ago

huh, still cannot merge this with master, there are merge conflicts

germanrio commented 11 years ago

I'll check

germanrio commented 11 years ago

I hope, this is the correct one, for me this change is a fast forward merge to the actual master.

paulmillr commented 11 years ago

ah sorry, forgot about this. this requires more general implementation in brunch that will auto-detect ALL deps

skevy commented 11 years ago

@paulmillr can you be a little more specific about this? I would really like to get this integrated into stylus-brunch proper so that I can stop using my fork, and the latest version of stylus-brunch does not accommodate the changes that are in this pull request.

paulmillr commented 11 years ago

@skevy this affects all brunch plugins, right? So, why not make a general solution for all brunch plugins that will make the patch unneeded?