search

brunch / stylus-brunch

Adds Stylus support to Brunch
MIT License
21 stars 2 forks source link

add lost grid support #39

Closed javimosch closed 8 years ago

es128 commented 8 years ago

Thanks for your contribution, but this PR is not in good shape to be merged.

For one thing, you have 3 commits here for a 2-line change. You also reference a new dependency which has not been added to package.json.

But ultimately I think it would be better if you could follow through on what you were doing with that first commit - allowing users to install any stylus plugins they like.

Simply installing and using this plugin might not make sense for all users.

Closing for now, but would consider re-opening if you amend the PR to account for this feedback. Or you could just open a new one.

javimosch commented 8 years ago

thanks, I think you are right.