bsoc-bitbyte / myLeave

myLeave is a user-friendly app that streamlines leave request submissions and management.
4 stars 14 forks source link

Fixes #3 Made the changes to the necessary XML for handling login activity #5

Closed ritankarsaha closed 3 months ago

ritankarsaha commented 3 months ago

Overview

FIXES #3

  1. This PR fixes or fixes part of #3
  2. This PR does the following: [
    1. This PR adds modifies the activity_login.xml file inside the layout folder to modify the login page accoridngly as displayed in the figma design.
    2. This PR also adds a background.png file in the drawable folder of the res folder to render the background image into the activity_login.xml file.

Essential Checklist

Proof that changes are correct

Screenshot 2024-06-03 at 1 42 03 PM Screenshot 2024-06-03 at 1 42 41 PM Screenshot 2024-06-03 at 1 43 05 PM

This proves that the changes made are authentic and it is properly rendered back into activity_login.xml file.

PR Pointers

Thank You.

ritankarsaha commented 3 months ago

@Agrim2112 I have fixed the issue #3 and also opened a PR for the same #5

ritankarsaha commented 3 months ago

@Agrim2112 I have made all the necessary changes and pushed a new commit into the PR-

  1. Giving proper ID to all views according to the convention.
  2. The EditText options have been made using custom edit text defined in the drawable folder separately.
  3. Used Relative Layout to add overlapping between the image and Card View.

PROOF OF CHANGES:-

Screenshot 2024-06-04 at 5 20 19 PM Screenshot 2024-06-04 at 5 20 37 PM

Thank You.