search

bthurlow / nativescript-imagecropper

A nativescript image cropping plugin.
Other
49 stars 35 forks source link

Adding support for webpack #6

Closed Cayan closed 7 years ago

Cayan commented 7 years ago

@shiv19 I've been working with version 0.0.7 of this plugin and it has been working properly with webpack

shiv19 commented 7 years ago

@Cayan Today we were having a conversation regarding this with bradmartin, in the NS slack channel for plugins, removing the .js extension is actually required for it to work with webpack. I've faced this problem with the statusbar plugin as well. I'm trying to find @bthurlow on social media. do you have any lead?

bthurlow commented 7 years ago

What can I do for you @shiv19?

shiv19 commented 7 years ago

can you merge this pr? @bthurlow

shiv19 commented 7 years ago

capture

We were talking about this on plugins channel in NS community slack

bthurlow commented 7 years ago

I merged and sent you a collab invite, I cannot build and release though as I'm no longer doing NS dev.

shiv19 commented 7 years ago

sure, I'll take care of this 👍

shiv19 commented 7 years ago

@bthurlow with your permission, I would like to refactor your plugin into the latest Nativescript plugin seed. https://github.com/NativeScript/nativescript-plugin-seed this one

bthurlow commented 7 years ago

Sure.

shiv19 commented 7 years ago

@bthurlow, and how to publish the plugin with your user name to npmjs? I think you'll have to do the publishing part. I'll let you know when I finish doing this migration

bthurlow commented 7 years ago

Looks like I can add you to the project in npmjs. Do you have a username I can send the invite too for npmjs?

shiv19 commented 7 years ago

yes I do, my username on npmjs is multishiv19

bthurlow commented 7 years ago

You should have access now.

shiv19 commented 7 years ago

Yes. got it. Thanks a lot, @bthurlow :D , and I got to learn many things from your code. It will surely help me build my next plugin :)

shiv19 commented 7 years ago

Version 0.1.0 is now out! it supports latest {N} :)

shiv19 commented 7 years ago

Also, now there is no longer need to declare the activity in the app's manifest file for android. the plugin does this. :) @bthurlow

shiv19 commented 7 years ago

Also, most of the issues have been closed :)

shiv19 commented 7 years ago

@bthurlow please add me as a contributor to nativescript-maskedinput repo

Cayan commented 7 years ago

whoaa, lots of improvements here! I'm happy to see improvements in this plugin, it works great and there is also a lot to improve!

I've mentioned before that I had it working on my environment, there was a nasty post-build script to fix it on my project.

romulowspp commented 7 years ago

Can I become a collaborator as well? I work with @Cayan :)