search

bthurlow / nativescript-imagecropper

A nativescript image cropping plugin.
Other
49 stars 35 forks source link

fix: opening from modal borks UI. #87

Closed davecoffin closed 2 years ago

davecoffin commented 2 years ago

If you open the VC from a modal, the root app UI gets all wonky. This fixes that.

davecoffin commented 2 years ago

@shiv19 @bthurlow any concerns?

shiv19 commented 2 years ago

@davecoffin thanks for the PR, I'll review it today :)

davecoffin commented 2 years ago

@shiv19 any thoughts/concerns on this?

shiv19 commented 2 years ago

@davecoffin Sorry I didn't get to this on the day I last commented here. However, I did get around to it today thanks to you for reminding about this. I've added tests to the demo app to test Modal pages. Also I've updated the demo app to use NativeScript 8. You're changes are now live in version 4.0.2 nativescript-imagecropper@4.0.2

Cheers! Thank you for this PR <3