search

byteburgers / react-native-autocomplete-input

Pure javascript autocomplete input for react-native
https://byteburgers.com/autocomplete
MIT License
805 stars 255 forks source link

Fix ViewPropTypes warning #238

Closed ajenkins closed 2 years ago

ajenkins commented 2 years ago

After upgrading to React Native 0.68, I started seeing this warning: ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.

Personally, I don't love the suggested solution, but I don't know what the alternative is (I asked about better alternatives here).

I based this PR off of a similar PR for react-native-maps.

It's unfortunate that this fix requires adding the first and only dependency to this package, but without adding deprecated-react-native-prop-types to dependencies, anyone who wants to use this package would need to have their own copy of deprecated-react-native-prop-types installed, which would be annoying.

ajenkins commented 2 years ago

I believe this fixes #222

ajenkins commented 2 years ago

Update: Got a reply from someone on the React team about the "right" way to fix this. Apparently they want everyone to start using Flow or Typescript instead of relying on prop types.

Migrating to Flow or Typescript would be a much bigger change though, and probably isn't worth doing just to fix this one warning.

DavidAmyot commented 2 years ago

Personally, I would greatly appreciate for this pr to be merged since this is the only package I have left which creates this warning :)

Thanks for the great work!

mak12 commented 2 years ago

Hi, Any update on this?

DavidAmyot commented 2 years ago

Hi, Any update on this?

I wish! @mrlaessig Any chances of this getting merged?

Thanks :)

anija commented 2 years ago

This library is now raising an error (was a warning), when opgrading to react native 0.69. Merging this PR now it's pretty important.

thomasviaud commented 2 years ago

Any news on this PR ? It is breaking RN 0.69.

thomasviaud commented 2 years ago

If some people need that urgently, you can still use https://www.npmjs.com/package/patch-package. Working well applying changes in this PR. Not ideal but can save a build.

ericmager commented 2 years ago

having the same issue. would be great to merge this!