bytesparadise / libasciidoc

A Golang library for processing Asciidoc files.
Apache License 2.0
205 stars 25 forks source link

Add basename function to sgml FuncMap #1104

Closed davidgamba-au closed 1 year ago

davidgamba-au commented 1 year ago

This function is necessary to allow custom backends to only use the basename of an image in cases where images are stored as attachments.

blockImageTmpl = `<image ><attachment filename="{{ basename .Src }}" /></image>`
codecov[bot] commented 1 year ago

Codecov Report

Merging #1104 (3d22367) into master (f760dcb) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files          89       89           
  Lines        8940     8941    +1     
=======================================
+ Hits         6937     6938    +1     
  Misses       1509     1509           
  Partials      494      494           
xcoulon commented 1 year ago

@davidgamba-au could you solve the conflicts on the PR, please?

DavidGamba commented 1 year ago

@xcoulon merge conflicts fixed! Thanks for the quick review!

DavidGamba commented 1 year ago

@xcoulon rebased the latest master again. PTAL when you have a chance. Thanks!

xcoulon commented 1 year ago

thanks @DavidGamba!