search

c-frame / aframe-gltf-model-plus

gltf-model-plus component to load glb file with hubs extensions
https://c-frame.github.io/aframe-gltf-model-plus/
Mozilla Public License 2.0
10 stars 4 forks source link

Generate a networked id for waypoints #15

Closed vincentfretin closed 2 months ago

vincentfretin commented 2 months ago

One thing that changed in recent hubs blender addon (compared to two years ago) is that networked id is not generated anymore when exporting. So I need to fix my code for waypoint to create the networked it. I kind a followed the discussion in hubs repo at the time, that was to allow importing several times the glb in hubs and be sure to have a unique id, based on object hierarchy if I remember. I wrote some code to create an id for a node in tree, I may just use that, indexOfImportedGlb+NodeId, but the order of imported glb must be deterministic so I end up with the same networked if for all participants.

vincentfretin commented 2 months ago

From @Imaginer on discord:

Uh, Networked IDs are generated on export for me. See this PR for details: https://github.com/MozillaReality/hubs-blender-exporter/pull/137 I kinda remember there were conversations around that, but I don't think anything got implemented other than moving the generation to just before export rather than storing the ID with the component.

So that's probably an issue with my old blend file and hubs addon way to handle the migration. I will investigate this further.

vincentfretin commented 2 months ago

I definitely have no issue with a new scene, it exports with generated networked id indeed. I'll try a previous version of the hubs exporter with my old blend file to see at which version this breaks. So nothing to do in this repo, closing.