search

c-frame / aframe-gltf-model-plus

gltf-model-plus component to load glb file with hubs extensions
https://c-frame.github.io/aframe-gltf-model-plus/
Mozilla Public License 2.0
10 stars 3 forks source link

particle-emitter - add the component and inflator #54

Closed uhunkler closed 1 month ago

uhunkler commented 1 month ago

and the related files. Plus the "lib-hubs": "github:mozillareality/lib-hubs#master" dependency.

uhunkler commented 1 month ago

When I remove examples/playground/625d696f-1264-4616-8ac9-72b205ed3e63.png the particle image will not be loaded. I tried to use the link to the particle image in the CDN but that does not work. The sounds linked from an external URL also needed to be saved in the playground folder.

Which URL to the particle image do you think would work without saving it in the playground folder?

vincentfretin commented 1 month ago

Ah it's in your playground folder, I thought it was in outdoor-festival. Ok keep it in the folder then. And in outdoor-festival scene, is it working from the cdn? The sounds are working, so I don't see why the image won't work.

vincentfretin commented 1 month ago

If you use https://cdn.jsdelivr.net/gh/c-frame/outdoor-festival@d3e76c8/625d696f-1264-4616-8ac9-72b205ed3e63.png in your playground scene, it should work, but yeah keep the file locally like the other files.

vincentfretin commented 1 month ago

We may need to set .setCrossOrigin('anonymous') on the loader.

 const textureLoader = new TextureLoader().setCrossOrigin('anonymous');
 const texture = await textureLoader.loadAsync(src);

This is what hubs and aframe do on their loaders.

uhunkler commented 1 month ago

If you use https://cdn.jsdelivr.net/gh/c-frame/outdoor-festival@d3e76c8/625d696f-1264-4616-8ac9-72b205ed3e63.png in your playground scene, it should work, but yeah keep the file locally like the other files.

When I use that link I get an event error. Even when I add setCrossOrigin('anonymous') on the loader. The CDN link should work, I know, but for any reason it doesn't.