vincentfretin
commented
3 weeks ago For lib-hubs, as I said in https://github.com/c-frame/aframe-gltf-model-plus/issues/5#issuecomment-2061708671 can you create a PR there, hubs is still using threer147 so the PlaneBufferGeometry warning should also be fixed there. If they don't merge it, we'll fork it in c-frame organization like you suggest.
For NAF, making it optional with just condition like you did is enough. Adding events and handling it elsewhere would make the code less understandable I think.
Following from #4
Dear @vincentfretin,
here are the changes applied so far to my fork. One note: I introduced my own fork of lib-hubs in the dependencies because of https://github.com/Elettrotecnica/lib-hubs/commit/94cb865e069261a00729f3fc8b48310be1eb39d0. I could open a PR there as well for this, or you could fork lib-hubs into c-frame so it "stays in the family".
The current changes concerning NAF make it so that I can load a model on my non-NAF scene using the build from this PR, but I think it would be nice that NAF behavior on gltf-model-plus was somewhat more "pluggable". One way to do it could be to emit events during the inflation, rather than setting the components explicitly, then react to them somewhere else in our code. What do you think about it?
Ciao