Implement stream caching for collection and document listeners

cachapa / firedart

A dart-native implementation of the Firebase Auth and Firestore SDKs

https://pub.dev/packages/firedart

Apache License 2.0

174 stars 62 forks source link

Implement stream caching for collection and document listeners #57

Closed cenomla closed 3 years ago

cenomla commented 3 years ago

Change log:

Implement stream caching with request lifetime tied to stream listeners
Fix stream data crossing bug

This fixes issues #53 and #52 and maybe #55

cachapa commented 3 years ago

Thanks for the contribution.

You seem to have changed the formatting for lines which weren't touched, which makes code reviewing a bit more difficult. The quality gate checks for formatting anyway, so the merge won't go through until it's satisfied.

Just run dart format . in the firedart directory. It might take a while (30s on my machine) due to the generated protobuff files.

cachapa commented 3 years ago

You might also want to rebase on top of the latest commit, which fixes some issues with the quality gate

cenomla commented 3 years ago

Rebased and re-formatted. Looks like checks are passing now @cachapa

cachapa commented 3 years ago

Thanks!