search

cachapa / firedart

A dart-native implementation of the Firebase Auth and Firestore SDKs
https://pub.dev/packages/firedart
Apache License 2.0
174 stars 62 forks source link

Could you please support "signInWithCustomToken" in FirebaseAuth? #98

Closed eximius313 closed 1 year ago

eximius313 commented 1 year ago

Currently FirebaseAuth supports only signIn(email, password) and signInAnonymously()

Could you please support signInWithCustomToken according to the Reference docs?

Thank you in advance.

cachapa commented 1 year ago

Sorry but this library is currently on maintenance mode.

I would be happy to accept contributions though.

eximius313 commented 1 year ago

Ok, do you have any guidelines? I assume that I should start with FirebaseAuth and AuthGateway?

cachapa commented 1 year ago

Yeah, I guess adding a FirebaseAuth.signInWithCustomToken() and the relevant downstream functionality in AuthGateway would be appropriate.

A couple of tests would also be nice. I know testing against Firebase isn't easy but it's currently the only option.

eximius313 commented 1 year ago

Sure! Thanks.

cachapa commented 1 year ago

Check PR #97 perhaps it fits your use case, or at least for inspiration.

eximius313 commented 1 year ago

@cachapa, could you please take a look at my PR (https://github.com/cachapa/firedart/pull/104)?

cachapa commented 1 year ago

Hi @eximius313 thanks for your contribution! The code looks good, I just had a couple of suggestions and questions which I think will be quick to address.