Sign APK - Githubissues

cagnulein commented 8 months ago

@IzzySoft could you please check if this apk https://github.com/cagnulein/QZCompanionNordictrackTreadmill/actions/runs/7247410089/artifacts/1121176980 satisfies the fdroid needs?

@victorypoint could you just check if this apk https://github.com/cagnulein/QZCompanionNordictrackTreadmill/actions/runs/7247410089/artifacts/1121176980 still works? i just signed it to fix the #61

let me know guys then I will merge this

IzzySoft commented 8 months ago

My library scanner says it looks fine:

Libraries detected:
-------------------
* Android Support v4 (/android/support/v4): Development Framework, Apache-2.0
* AndroidX Activity (/androidx/activity): Utility, Apache-2.0
* Android Jetpack Annotations (/androidx/annotation): Utility, Apache-2.0
* Arch (/androidx/arch): Utility, Apache-2.0
* AppCompat (/androidx/appcompat): Utility, Apache-2.0
* Cardview (/androidx/cardview): UI Component, Apache-2.0
* Android Support Library collections (/androidx/collection): Utility, Apache-2.0
* Concurrent (/androidx/concurrent): Utility, Apache-2.0
* Constraint Layout Library (/androidx/constraintlayout): Utility, Apache-2.0
* Coordinatorlayout (/androidx/coordinatorlayout): UI Component, Apache-2.0
* Androidx Core (/androidx/core): Utility, Apache-2.0
* AndroidX Cursor Adapter (/androidx/cursoradapter): Utility, Apache-2.0
* Android Support Library Custom View (/androidx/customview): UI Component, Apache-2.0
* Documentfile (/androidx/documentfile): UI Component, Apache-2.0
* Drawerlayout (/androidx/drawerlayout): UI Component, Apache-2.0
* Dynamicanimation (/androidx/dynamicanimation): UI Component, Apache-2.0
* AndroidX Fragment (/androidx/fragment): UI Component, Apache-2.0
* Interpolator (/androidx/interpolator): UI Component, Apache-2.0
* androidx.legacy (/androidx/legacy): Utility, Apache-2.0
* Lifecycle (/androidx/lifecycle): Utility, Apache-2.0
* Loader (/androidx/loader): Utility, Apache-2.0
* AndroidX Local Broadcast Manager (/androidx/localbroadcastmanager): Utility, Apache-2.0
* Print (/androidx/print): Utility, Apache-2.0
* Recyclerview (/androidx/recyclerview): Utility, Apache-2.0
* Android Activity Saved State (/androidx/savedstate): Utility, Apache-2.0
* Tracing (/androidx/tracing): Utility, Apache-2.0
* Transition (/androidx/transition): UI Component, Apache-2.0
* Vectordrawable (/androidx/vectordrawable): UI Component, Apache-2.0
* Android Jetpack VersionedParcelable (/androidx/versionedparcelable): Utility, Apache-2.0
* Viewpager (/androidx/viewpager): UI Component, Apache-2.0
* AndroidX Widget ViewPager2 (/androidx/viewpager2): UI Component, Apache-2.0
* AdbLib (/com/cgutman/adblib): Utility, BSD-3-Clause
* RemoteAdbShell (/com/cgutman/androidremotedebugger): Utility, Apache-2.0
* Google Material Design (/com/google/android/material): Utility, Apache-2.0
* Google Core Libraries for Java 6+ (/com/google/common): Utility, Apache-2.0
* Kotlin (/kotlin): Utility, Apache-2.0
* kotlinx.coroutines (/kotlinx/coroutines): Utility, Apache-2.0
* IntelliJ IDEA (/org/intellij): Utility, Apache-2.0

No offending libs found.

But it's a debug build, signed with a debug key. It should be signed by a release key if it shall go to my repo.

cagnulein commented 8 months ago

@IzzySoft my bad, try this https://github.com/cagnulein/QZCompanionNordictrackTreadmill/actions/runs/7250732117/artifacts/1121843791

IzzySoft commented 8 months ago

That one looks excellent, thanks!

cagnulein commented 8 months ago

ok let's wait the confirmation from @victorypoint before merging it, even if i guess it will be ok

victorypoint commented 8 months ago

@cagnulein, okay I just gave this a good test and it works rock solid on my C2950. All auto-incline and workout features work fine.

cagnulein commented 8 months ago

thanks! i'm pushing into master so! Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno lun 18 dic 2023 alle ore 20:25 Al Udell @.***> ha scritto:

@cagnulein https://github.com/cagnulein, okay I just gave this a good test and it works rock solid on my C2950. All auto-incline and workout features work fine.

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/QZCompanionNordictrackTreadmill/pull/69#issuecomment-1861407459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWEQKA3TWG7OAI2RR73YKCKCPAVCNFSM6AAAAABAZJ7UHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRRGQYDONBVHE . You are receiving this because you were mentioned.Message ID: @.***>

IzzySoft commented 8 months ago

Yay! Please let me know when the first release with the new signature goes live. I need to take proper actions then on my end, too, so my repo accepts it. And congrats!

cagnulein commented 8 months ago

I already did, check this https://github.com/cagnulein/QZCompanionNordictrackTreadmill/releases/tag/3.3.22

Thanks

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno lun 18 dic 2023 alle 22:47 Izzy @.***> ha scritto:

Yay! Please let me know when the first release with the new signature goes live. I need to take proper actions then on my end, too, so my repo accepts it. And congrats!

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/QZCompanionNordictrackTreadmill/pull/69#issuecomment-1861738492, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWA7LVB46TCXQXYRHNTYKC2YLAVCNFSM6AAAAABAZJ7UHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRRG4ZTQNBZGI . You are receiving this because you modified the open/close state.Message ID: @.*** com>

IzzySoft commented 8 months ago

updated AllowedSigningKeys to the release key √
re-enabled auto-updates √
fetched latest release √
triggered new index to be build, to confirm all is in place … Ooof. Huh? Oh.
fixed AllowedSigningKeys to point to the Certificate (and not the public key) :see_no_evil: √
triggered new index to be build again, to confirm all is in place √
checking… Ah, we can remove the AntiFeature now – it's no longer a debug build :partying_face:
triggered new index to be build yet another time, to confirm all is in place √

All set then, thanks!

Last question: would there be some screenshots, or at least an icon (not the green Andy)? It looks a bit "naked" without:

cagnulein commented 8 months ago

Do you need the icon in the apk or even here?

IzzySoft commented 8 months ago

Ideally in Fastlane structure, see my Fastlane Cheat Sheet. If that's asked too much, you can provide them here – and if you want I return them in Fastlane format via PR so you can adjust them whenever needed. Including app short- and full descriptions.

cagnulein commented 8 months ago

Ok I can do it but not right now :) Is it a problem for now leaving in this way? Other than the fact that it's ugly?

IzzySoft commented 8 months ago

Other than the fact that it's ugly?

Consider it a "cosmetical issue" then :rofl: And my offer stands. If you provide me any of those graphics, I can add them here ASAP – and when you feel ready to accept it, ship things back in Fastlane structures via a PR.

cagnulein commented 8 months ago

ok thanks, i will try to do my best!

cagnulein / QZCompanionNordictrackTreadmill

Sign APK #69