Inadequate textstrings

[GoogleCodeExporter]

1
Use "Cancel" instead of "cancel" in "pcsx2/gui/Panels/BiosSelectorPanel.cpp" 
line 139,
and in "pcsx2/gui/Panels/PluginSelectorPanel.cpp" line 459.
2
In "pcsx2/gui/Panels/MemoryCardListPanel.cpp" line 366,
instead of using "This will copy the contents of the memory card in slot %u 
over the memory card in slot %u. ",
use "This will copy the contents of the memory card in slot %u and overwrite 
the memory card in slot %u with it. "
3
In "pcsx2/x86/sVU_zerorec.cpp" line 363,
instead of using "Out of Memory (sorta): The SuperVU recompiler was unable to 
reserve the specific memory ",
use "Out of Memory (sorta): The superVU recompiler was unable to reserve the 
specific memory ".
If "sVU" is short for "superVU", then the name ought to be "superVU", and not 
"SuperVU", to avoid confusions.

The linenumbers are valid for r4288.

I originally posted this in i909, but to no effect.
Just in case this was dismissed due to issue irrelevascy, I am here posting it 
again under a issue of it's own.
Considering that PCSX2 is under translationface (more or less),
I urge that this issue is labeled urgent.

Thank you.

Original issue reported on code.google.com by pg...@yahoo.se on 9 Feb 2011 at 9:31

[GoogleCodeExporter]

you picky bastard :P

however 2 should be "This will copy the entire contents of the memory card in 
slot %u to the memory card in slot %u. "

That would be a better use of english.

Original comment by refraction on 21 Feb 2011 at 5:29

[GoogleCodeExporter]

sorted what needed sorting in r4340

Original comment by refraction on 22 Feb 2011 at 7:25

• Changed state: Fixed

[GoogleCodeExporter]

Found another annoying textstring:
In "Main", in the translation files, "If loading from an ISO image, this error 
may be caused by an unsupported ISO image type or bug in PCSX2 ISO image 
support." ought to be replaced with "If loading from an ISO image, this error 
may be caused by an unsupported ISO image type or a bug in the PCSX2 ISO image 
support.", otherwise it implies that bugs are supported - Yes?

Original comment by pg...@yahoo.se on 26 Feb 2011 at 11:31

[GoogleCodeExporter]

And another one:
File: \SVN\pcsx2\gui\Dialogs\StuckThreadDialog.cpp
Line: 34-35
            L"The thread '%s' is not responding.  It could be deadlocked, or it might "
            L"just be running *really* slowly."
ought to be:
            L"The thread '%s' is not responding. "
            L"It could be deadlocked, or it mightjust be running *really* slowly."
Yes?

Original comment by pg...@yahoo.se on 26 Feb 2011 at 3:07

[GoogleCodeExporter]

Don't see an issue with the 2nd report. The first one is valid though, so 
fixing it.

Original comment by ramapcsx2 on 26 Feb 2011 at 9:51

[GoogleCodeExporter]

With the 2nd report I ment that it would look nicer.
Once the %s variable is filled, the first line will be about three times as 
long as the second.
Thanks anyway.

Original comment by pg...@yahoo.se on 26 Feb 2011 at 11:26

[GoogleCodeExporter]

Did you actually make a test? If I'm correct PCSX2 have some kind of 
auto-wrapping.

By the way, do not hesitate do to a full review of all strings. I want to 
freeze string as much as possible soon. Otherwise translation will progress in 
the wrong direction :)

Note: I commit the first one so I can update my pot files.

Original comment by gregory....@gmail.com on 27 Feb 2011 at 8:58

[GoogleCodeExporter]

Some more suggestions:

1
File: \SVN\pcsx2\gui\Panels\GSWindowPanel.cpp
Line: 65
        L"You can still toggle fullscreen display at any time using alt-enter."
ought to be:
        L"You can still toggle fullscreen display at any time using Alt + Enter."
according to me.

2
File: \SVN\pcsx2\gui\Panels\GSWindowPanel.cpp
Line: 74-75
        L"Completely closes the often large and bulky GS window when pressing "
        L"ESC or suspending the emulator."
ough to be:
        L"Completely closes the often large and bulky GS window when pressing "
        L"Esc or suspending the emulator."
according to me.

3
File: \SVN\pcsx2\gui\Panels\SpeedhacksPanel.cpp
Line: 130-132
        L"Setting higher values on this slider effectively reduces the clock speed of the EmotionEngine's "
        L"R5900 core cpu, and typically brings big speedups to games that fail to utilize "
        L"the full potential of the real PS2 hardware."
ought to be:
        L"Setting higher values on this slider effectively reduces the clock speed of the EmotionEngine's "
        L"R5900 core CPU, and typically brings big speedups to games that fail to utilize "
        L"the full potential of the real PS2 hardware."
according to me.

4
File: \SVN\pcsx2\gui\Panels\SpeedhacksPanel.cpp
Line: 183-184
        L"Uses SSE's Min/Max Floating Point Operations instead of custom logical Min/Max routines. "
        L"Known to break Gran Turismo 4, Tekken 5."
ought to be:
        L"Uses SSE's Min/Max Floating Point Operations instead of custom logical Min/Max routines. "
        L"Known to break Gran Turismo 4 & Tekken 5."
according to me.

5
File: \SVN\pcsx2\gui\Panels\SpeedhacksPanel.cpp
Line: 215
        L"Check HDLoader compatibility lists for known games that have issues with this. (Often marked as needing 'mode 1' or 'slow DVD'"
ought to be:
        L"Check HDLoader compatibility lists for known games that have issues with this (often marked as needing 'mode 1' or 'slow DVD')."
according to me.

6
File: \SVN\pcsx2\gui\Panels\VideoPanel.cpp
Line: 307-309
        L"Removes any benchmark noise caused by the MTGS thread or GPU overhead.  This option is best used in conjunction with savestates: "
        L"save a state at an ideal scene, enable this option, and re-load the savestate.\n\n"
        L"Warning: This option can be enabled on-the-fly but typically cannot be disabled on-the-fly (video will typically be garbage)."
ought to be:
        L"Removes any benchmark noise caused by the MTGS thread or GPU overhead.  This option is best used in conjunction with savestates: "
        L"save a state at an ideal scene, enable this option, and re-load the savestate.\n\n"
        L"Warning: This option can be enabled on-the-fly but typically cannot be disabled in the same way (video will typically be garbage)."
according to me.

Original comment by pg...@yahoo.se on 28 Feb 2011 at 2:19

[GoogleCodeExporter]

And another one:
In the "Devel" file, "Disasm of COP0 instructions (MMU, cpu and dma status, 
etc)."
 ought to be
"Disasm of COP0 instructions (MMU, CPU and DMA status, etc)."
according to me.

Original comment by pg...@yahoo.se on 5 Mar 2011 at 4:49

[GoogleCodeExporter]

I guess this issue is dead, however...

1.
File: 1. the "Main" translation file
      2. \SVN\pcsx2\gui\Dialogs\McdConfigDialog.cpp
\n
\n
Note: 'Rename' and 'Delete' require to apply pending changes first.
ought to be:
\n
\n
Note: 'Rename' and 'Delete' require applying of pending changes first.
according to me.

2.
File: 1. the "Main" translation file
      2. \SVN\pcsx2\gui\Panels\MemoryCardListPanel.cpp 
Error: Please apply pending changes before proceeding.
ought to be:
Error: Pending changes must be applied before proceeding.
according to me.

Original comment by pg...@yahoo.se on 14 Mar 2011 at 3:31

[GoogleCodeExporter]

Well, I read your later reports (it's quite hard to notice the often small 
changes you did!) and imo they're all minor.
So thanks for going over it but I think we're fine by now :)

Original comment by ramapcsx2 on 14 Mar 2011 at 2:14

[GoogleCodeExporter]

File: 1. the "Tertiary" translation file
      2. pcsx2/gui/ConsoleLogger.cpp:417
"Its nice and readable."
ought to be:
"It's nice and readable."
according to me.

Original comment by pg...@yahoo.se on 2 Apr 2011 at 8:21

[GoogleCodeExporter]

Collected and updated my unfixed suggestions in a textfile.

Original comment by pg...@yahoo.se on 2 Apr 2011 at 11:18

Attachments:

• Stringlist.txt

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Any interest in this?

Original comment by pg...@yahoo.se on 11 Nov 2011 at 4:11

[GoogleCodeExporter]

To be fair, we care a lot more about translations on release time ;)

Original comment by ramapcsx2 on 11 Nov 2011 at 11:07

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Maybe a patch-file will catch your interest.

Original comment by pg...@yahoo.se on 22 Jun 2012 at 10:33

Attachments:

• TextCleanups.patch

[GoogleCodeExporter]

Strings are frozen now for 1.0. Changing anything that pops up in the GUI would 
require re-translations.

Why are you moving the ellipsis in code comments?

-// Maybe useful,maybe not... no harm in attaching it. :D
+// Maybe useful,maybe not ... no harm in attaching it. :D

Original comment by ramapcsx2 on 22 Jun 2012 at 12:02

[GoogleCodeExporter]

Let me ask the question I think rama really meant: why are you changing 
comments at all?

Original comment by sudonim1 on 22 Jun 2012 at 12:13

[GoogleCodeExporter]

Also your grammar sucks (excerpt from the patch):

-           // its final vu1 xgkick packet (!curP1Packs)...
+           //  it's final vu1 xgkick packet (!curP1Packs) ...

I can't trust you as an editor if you make such fundamental mistakes.  Half of 
your patch (apart from the bizarre spacing changes) is also changing VUs to 
VU's etc., which while arguable is fine and unambiguous in the former spelling.

Original comment by sudonim1 on 22 Jun 2012 at 12:28

[GoogleCodeExporter]

Removed comment modifications, except those with textstrings,
 and the one in "pcsx2/Vif0_Dma.cpp" since it bugs me.
Old:
// Run VU0 until finish, don't add cycles to EE
// because its vif stalling not the EE core...
New:
// Run VU0 until finish - don't add cycles to EE
//  because it's the VIF stalling not the EE core ...

Added some new stuff I stumbled upon.

Finally, I sure don't expect you to apply this in PCSX2 1.0.0.
Afterwards it might (if nothing else) give us translators something to do.
Thanks for your indulgence.

Original comment by pg...@yahoo.se on 22 Jun 2012 at 8:24

Attachments:

• TextCleanups.patch

[GoogleCodeExporter]

// Run VU0 until finish - don't add cycles to EE
//  because it's the VIF stalling not the EE core ... << why the extra space?

As for the suspension dots, I prefer no space before them. Open your notepad 
and you'll see "About..." not "About ...". In menus, "Save" vs "Save..." means 
the latter opens a dialog and it ain't "Save ..." either.

Original comment by KrossX3 on 23 Jun 2012 at 9:02

[GoogleCodeExporter]

OK.
I removed the suspension dots entries and added some even more stuff I stumbled 
upon.

Original comment by pg...@yahoo.se on 23 Jun 2012 at 9:29

Attachments:

• TextCleanups.patch

[GoogleCodeExporter]

Alright, some review then.

175, 204, 211: Why the weird spacing? I would've assumed the wrapping to be 
automatic.
224: "The" twice, and seems wrong to begin with. 
230: Similar to 224.
243: Why the extra space after L" ?

General: Plural acronym should be ACRONYMs as far as I know, instead of 
ACRONYM's that is. Otherwise it's genitive.

I ain't alone in that it seems: 
http://answers.google.com/answers/threadview?id=499296

Special: Why change "dood" for "dude" ? If I remember correctly, the Prinnies 
in Disgaea got translated saying "dood" so it could be considered, and maybe 
is, a reference to that. A reference to a PS2 game, in a PS2 emulator. Quite 
befitting I think.

Original comment by KrossX3 on 23 Jun 2012 at 9:59

[GoogleCodeExporter]

The spacing in "175, 204, 211" etc. should make it easier to read.
If we have a new line that's not a new sentence start with a space.
I guess it's a matter of opinon.
I find it quite comfortable when reading from a screen.
How about keeping them to raise awareness?

"a host CPU with MMX, SSE, and SSE2 extensions"...
uhm, yes - spelling errors.

ACRONYMs...
Blast.
I find it more comfortable with "'s" under all circumstances.
Anyway, removed such.
Corrected some other "'s" entries I spotted.

"dude" can be spelled "dood"? - OK.
Removed it.

Thanks dude.

Original comment by pg...@yahoo.se on 23 Jun 2012 at 11:43

Attachments:

• TextCleanups.patch

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Original comment by pg...@yahoo.se on 24 Jun 2012 at 2:33

Attachments:

• TextCleanups.patch

[GoogleCodeExporter]

""dude" can be spelled "dood"? - OK" => Doodage 
https://www.youtube.com/watch?v=paP842ZZtB4 

10: That was correct, since PCSX2's in that case was genitive. Also, there's an 
extra space after "failure!" that can be removed.

23: Same as before, including the space.

36:41:51:132:380:583:591:609 Those were correct, as 10, 'twas genitive not 
plural. >_<

69: Can the b of "boot" be capitalized? I dunno where that string is used.

229:235:637:650: Oh, now it makes more sense but I still don't see the reason 
for the "the". "requires a CPU with STUFF" vs "requires CPU with the STUFF", 
that "the" makes it sound like the STUFF is borrowed. XD

Original comment by KrossX3 on 24 Jun 2012 at 4:18

[GoogleCodeExporter]

Can the b of "boot" be capitalized?
I can't find where it's used either, and since the other strings in the block 
arn't beginning with capital letter, let's leave it (for now).

"requires CPU with the STUFF"...
Well the STUFF here are units (at least literary), units that arn't necessarily 
included or required with a CPU (at least historically).
Without "the" STUFF sounds (to me) as ingrediences, like spices in a curryblend.

Corrected the other STUFF.

Original comment by pg...@yahoo.se on 24 Jun 2012 at 2:32

Attachments:

• TextCleanups.patch

[GoogleCodeExporter]

"Pentium with MMX!" vs "Pentium with MMX extention!" vs "Pentium with the MMX 
extention!" ... Hmmm ...

How about changing it so that instead it says

"The R5900-32 recompiler requires a host CPU with MMX, SSE, and SSE2."

Original comment by KrossX3 on 24 Jun 2012 at 3:31

[GoogleCodeExporter]

Yes, that sounds nice.

Original comment by pg...@yahoo.se on 24 Jun 2012 at 5:19

Attachments:

• TextCleanups.patch