calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
32.59k stars 8.06k forks source link

[CAL-4350] Accept stripe coupons on booking payment #12462

Open elliotblackburn opened 1 year ago

elliotblackburn commented 1 year ago

Is your proposal related to a problem?

I'm using Cal.com to help a family member run a small business. So far it's been very successful and the hosted version is great! Today they decided they need to give a discount to a customer but it doesn't seem like there's a way to do this with cal.com + stripe at the moment.

Describe the solution you'd like

I've had a look around the code and it looks like allow_promotion_codes is being set to true in some places which setup stripe checkout sessions, but for some reason coupons are not allowed on the booking payment page. I'm guessing it should just be a case of setting this property in the correct place for booking payments, but not knowing the code I'm struggling to find the right place.

Describe alternatives you've considered

The only alternative I can think of so far is to skip cal.com altogether for these bookings. They'd then generate a stripe payment link and enter the calendar invite manually. This would be fine for me, but would be a bit much for my family member and also means the clients booking get significantly less control.

I'm open to alternative solutions though!

Additional context

I'm very happy to contribute the code for this, it's been a while since I've worked in JS/TS though and I'm not all that familiar with the project layout an architecture. If someone can point me to where the checkout session is being setup in this case, I'd be happy to have a go at adding it in. As I understand, it should really just be a case of setting allow_promotion_codes to true.

Requirement/Document

None that I'm aware of.


House rules

CAL-4350

PeerRich commented 1 year ago

hmmm given my short research i am not sure if you can apply discount codes to Stripe Connect payments. The difference between stripe checkout (subscribing to Cal.com) and Stripe connect (paying other people for events) is that the Stripe Conenct API is a bit more limited

PeerRich commented 1 year ago

happy to reopen if I am wrong here

AntoineT7 commented 9 months ago

hey @PeerRich! according to Stripe Support, coupons can be applied to Stripe Connect payments. doesn't the payment need to go through Stripe Checkout regardless? either by collecting the payment and paying out or enabling connected accounts to accept payments directly?

jimfilippou commented 8 months ago

This would be a very interesting feature, at the moment I am limited and I am charging specific customers that I dont want to charge, mainly because they are already paying customers in other sectors of the business.

rafarc21 commented 6 months ago

I'd love to have this feature.

karinabao commented 4 months ago

I'd also love to have this feature

pannpichet commented 3 months ago

Bump. Would also like this feature.

hirefrank commented 2 months ago

+1

fabriziospadaro commented 2 months ago

+1

PeerRich commented 2 months ago

let me do more research and try and get this on the roadmap

fabriziospadaro commented 1 month ago

Hope this can make it to the 4.7 milestone, it's a much needed feature, for any marketing strategy to support coupons!