search

calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.7k stars 7.71k forks source link

[CAL-2978] Adapt Dialog to use Drawers on modals #13338

Open sean-brydon opened 8 months ago

sean-brydon commented 8 months ago

@shadcn UI has a great example of this. We should do something simular and ensure we match our design system.

Discussed with @Jaibles in DMs and we think this is a good approach as our modals can get a bit messy on mobile with some nasty scrolling.

From SyncLinear.com | CAL-2978

aakash2330 commented 8 months ago

please assign this to me

ppratik07 commented 8 months ago

@sean-brydon can you explain more a bit or can post a screen cap/video of this?

sean-brydon commented 8 months ago

@sean-brydon can you explain more a bit or can post a screen cap/video of this?

Hi - what i mean is our "Dialog" component should be swapped out for the Responsive Dialog + Modal like in the example of "ShadCn"

The designs for modal should match those in our figma file

aakash2330 commented 8 months ago

can outside contributors access the figma file ?

SwapnilSonker commented 8 months ago

May i work on it, please, assign me the issue. @sean-brydon

sean-brydon commented 8 months ago

May i work on it, please, assign me the issue. @sean-brydon

Hi - we don't assign issues but feel free to work on it and we will review your PR once its completed

Bhushankadam17 commented 7 months ago

this issue is not explained very well... am i suppose to replace all the dialogue boxes in the application?? please explain the issue i would like to work on it. @sean-brydon

dhruvkaravadiya commented 4 months ago

I found cal.com's figma design file but i am not able to locate the Dialog component, can you help me point out where it is, so that i can start working on this issue? @sean-brydon