calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.71k stars 7.72k forks source link

[CAL-3189] "Adding events to" appears multiple times in Google Calendar app settings #13787

Open aspiers opened 7 months ago

aspiers commented 7 months ago

Issue Summary

I have 4 Google Calendar accounts connected to my cal.com account. When I go to https://app.cal.com/apps/installed/calendar, I see two of these marked with the "Adding events to" label:

image

I believe this label is meant to indicate the calendar which is selected as the default to add to events to, for event types which don't specify a different account as an override:

image

In that case, there should only be one default, not two, so the fact that two "Adding events to" labels are simultaneously visible looks very much like a bug to me.

Assuming I'm right, I have a strong hunch that this bug is due to these calendars both having the same name, even though they come from different Google accounts. This appears to be confirmed by both of the following observations:

  1. Changing the default to a different calendar which has a unique name across all connected accounts results in only that uniquely named calendar having the "Adding events to" label.
  2. Changing the default back to the non-unique name causes two "Adding events to" labels to appear on both instances of that name, as shown in the first screenshot above.

Steps to Reproduce

  1. Obtain two Google accounts which both have a calendar with the same name.
  2. Connect those accounts to cal.com
  3. Check that the same calendar name can be seen in both accounts, similar to as shown in the first screenshot above.
  4. Select either of those calendars as the default calendar to add events to.

Actual Results

Two "Adding events to" labels are shown.

Expected Results

Only the calendar selected as default should have an "Adding events to" label next to it.

Technical details

Evidence

See screenshots above.

From SyncLinear.com | CAL-3189

Pritam-sd-dev commented 7 months ago

@aspiers We apologize for the inconvenience. Rest assured, the issue will be fixed as soon as possible.

Pritam-sd-dev commented 7 months ago

@aspiers i have tried to reproduce this bug but didnot find. Untitled design

aspiers commented 7 months ago

Could it be due to me sharing that calendar between accounts?

Pritam-sd-dev commented 7 months ago

@aspiers i didnot get "sharing that calender bw accounts" can you please tell little more in breif or like you can provide video as reference for sharing calender bw accounts so that i can reproduce the bug. thanks

aspiers commented 7 months ago

I have shared some of my calendars between Google accounts:

image

aspiers commented 7 months ago

Also @Pritam-sd-dev did your two calendars have exactly the same name?

Pritam-sd-dev commented 7 months ago

thanks for providing the info. yes name of calenders were same but let me try after sharing calender with multiple users

Pritam-sd-dev commented 7 months ago

Untitled design found the bug.

Pritam-sd-dev commented 7 months ago

@PeerRich is this a bug or its default behaviour ? if it is a bug. what should be the final behaviour ?

aspiers commented 7 months ago

Now that I understand what's happening it makes sense, but it is confusing at first so ideally we could think of a way to make it clearer.

emrysal commented 1 week ago

@PeerRich (@aspiers) It's a good question actually if this is a bug - I've managed to reproduce this by creating a shared calendar with multiple accounts and then connect both accounts to the same shared calendar - the following code powers this indicator, which is actually the same calendar:

destination={cal.externalId === props.destinationCalendarId}

I would argue this can be considered correct.

aspiers commented 1 week ago

Yeah I think we're all saying the same thing: it's correct, but definitely confusingly non-intuitive. Is there perhaps a simple text tweak which can be made to clarify? E.g. if more than one "Adding events to" is displayed on the page, also display some clarifying text (perhaps in a tooltip) which explains that they are the same calendar but accessible from different accounts? A UX expert should wade in here.