calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.26k stars 7.53k forks source link

[CAL-3437] Team events with "Organizer's default app" show no location on Booker #14046

Open jckw opened 6 months ago

jckw commented 6 months ago

Issue Summary

Team events with the location set to "Organizer's default app" are missing the "location" (e.g. Cal Video/Zoom) on the booker component and don't create meeting links. This means that the booking UI cannot be used to book Zoom calls.

Steps to Reproduce

  1. Ensure you have a default app for your profile (e.g. Cal Video)
  2. Create a team event (where you are one of the assigned team members)
  3. Select "Organizer's default app" in the event setup location field
  4. Preview the event
  5. See that there is no location rendered, and when booking the event, no link is created

Actual Results

CleanShot from Jack Weatherilt 2024-03-09 at 15 55 34@2x

Expected Results

Technical details

Evidence

CleanShot from Jack Weatherilt 2024-03-09 at 16 04 20@2x

CleanShot from Jack Weatherilt 2024-03-09 at 15 57 59@2x

CleanShot from Jack Weatherilt 2024-03-09 at 16 05 14@2x

From SyncLinear.com | CAL-3437

Shaik-Sirajuddin commented 5 months ago

Observed that the meeting links are created and sent via mail ( tested with google meet and cal video ) locally Although I see the location is not shown on booking page in prior.

Shaik-Sirajuddin commented 5 months ago

Its possible that the location is not chosen to be rendered "Organizer's default app" by purpose, this is because the organizer is chosen from the list of team members attending the meet and the team members are determined during booking confirmation . In case of robin round events , it may not be possible to know the team members attending meet in advance.

Alternatively the UI could be chosen to render location as "Video Conference" or some similar text to let the user know about location.

jckw commented 5 months ago

What appears in the UI is one thing, but it seems that what appears in the UI right now is tied to what appears in the admin UI.

I.e., when looking at the "Bookings" list, the link doesn't show up there either.

Screenshot attached of the UI I'm talking about:

CleanShot from Jack Weatherilt 2024-03-27 at 21 38 21

This is a big issue if you're self-hosting / don't want to use email as the primary mechanism for sharing links